Fix vulnerabilities as of 2025-04-08#352
Merged
tung2744 merged 7 commits intoauthgear:masterfrom Apr 9, 2025
Merged
Conversation
Collaborator
|
Contributor
Author
|
rickmak
approved these changes
Apr 8, 2025
tung2744
reviewed
Apr 8, 2025
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| bundler-cache: true | ||
| - run: make ruby-audit |
Collaborator
There was a problem hiding this comment.
So are we going to remove this step?
Contributor
Author
There was a problem hiding this comment.
No. Fixing vulnerabilities in gems are still needed.
Collaborator
There was a problem hiding this comment.
Yes, but I believe it should not block ci because it is development dependencies?
Anyway let me merge this first.
Member
There was a problem hiding this comment.
It will be very difficult to separate the development dependencies that might generate code that to be used in production. for example program used in go generate might have CVE that generate faulty code. So from compliance perspective, we will cover the dev dependencies.
The same logic follow, developer machine is in the compliance coverage too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.