Use fastlane to build and distribute iOS app#349
Merged
Conversation
louischan-oursky
changed the title
louischan-oursky
changed the title
tung2744
reviewed
Mar 21, 2025
Comment on lines
+84
to
+86
| .PHONY: react-native-set-versionCode | ||
| react-native-set-versionCode: | ||
| /usr/bin/sed -I "" "s/versionCode 1/versionCode $(shell date +%s)/" ./example/reactnative/android/app/build.gradle |
Collaborator
There was a problem hiding this comment.
What is this for? Seems not referenced anywhere. And I believe there should be other way to set the version code without using text replacement
Found it was referenced in the workflow.
Collaborator
There was a problem hiding this comment.
We can either:
- Use environment variable: https://docs.gradle.org/current/userguide/build_environment.html#sec:gradle_environment_variables
- Use gradle properties: https://docs.gradle.org/current/userguide/build_environment.html#sec:project_properties
Contributor
Author
There was a problem hiding this comment.
Will improve this when I do the android part.
tung2744
reviewed
Mar 21, 2025
Comment on lines
+88
to
+105
| .PHONY: react-native-build-unsigned-apk | ||
| react-native-build-unsigned-apk: | ||
| cd ./example/reactnative/android; \ | ||
| ./gradlew :app:assembleRelease | ||
|
|
||
| .PHONY: react-native-zipalign | ||
| react-native-zipalign: | ||
| "$(ANDROID_HOME)/build-tools/33.0.3/zipalign" -c -v 4 ./example/reactnative/android/app/build/outputs/apk/release/app-release-unsigned.apk | ||
|
|
||
| .PHONY: react-native-apksigner | ||
| react-native-apksigner: | ||
| "$(ANDROID_HOME)/build-tools/33.0.3/apksigner" sign \ | ||
| --ks $(ANDROID_KEYSTORE_PATH) \ | ||
| --ks-key-alias $(ANDROID_KEY_ALIAS) \ | ||
| --ks-pass pass:$(ANDROID_KEYSTORE_PASSWORD) \ | ||
| --key-pass pass:$(ANDROID_KEY_PASSWORD) \ | ||
| --out ./example/reactnative/android/app/build/outputs/apk/release/app-release-signed.apk \ | ||
| ./example/reactnative/android/app/build/outputs/apk/release/app-release-unsigned.apk |
Collaborator
There was a problem hiding this comment.
-
I believe you should be able to handle all this with fastlane
-
I think playstore requires an aab instead of apk.
Contributor
Author
There was a problem hiding this comment.
I just moved the code from the YAML file to here. Will use fastlane to distribute in another PR.
tung2744
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref DEV-2149
This PR was tested in https://github.com/authgear/authgear-sdk-js/actions/runs/13967733436