Skip to content

docs(passkey): drop retry cap from examples - #1810

Merged
yogeshchoudhary147 merged 1 commit into
mainfrom
docs/passkey-retry-cap
Oct 26, 2026
Merged

yogeshchoudhary147 merged 1 commit into
mainfrom
docs/passkey-retry-cap

Conversation

@yogeshchoudhary147

@yogeshchoudhary147 yogeshchoudhary147 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Removes MAX_ATTEMPTS from both identifier verification examples in examples/passkeys.md, and replaces the "Always cap retries" note.

The server owns the OTP attempt count. Once attempts run out, the error comes back without auth_session, so isRetryable is false and the loop stops. A client-side cap can stop the user before the server limit and force a new OTP.

Testing

Docs only, no code change.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated the passkey signup examples to continue retrying retryable token errors until the server indicates that no further attempts are allowed.
    • Clarified that the server determines the retry limit, replacing guidance to configure an application-side limit.

Co-Authored-By: Claude <noreply@anthropic.com>
@yogeshchoudhary147
yogeshchoudhary147 requested a review from a team as a code owner October 23, 2026 09:40
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 404f201 and a0487ce.

📒 Files selected for processing: 1
  • examples/passkeys.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The passkey signup examples now retry while token errors are marked retryable. The guidance states that the server controls the attempt limit and that retries stop when isRetryable becomes false.

Changes: Passkey signup verification retries

Layer / File(s) Summary
Update signup retry examples
examples/passkeys.md
Both signup examples replace the three-attempt cap with retries that continue for retryable PasskeyGetTokenError errors. The examples update verification requirements and throw other errors. The guidance says the server determines the attempt limit.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: subhankarmaiti

Merge Risk: ⚪ Minimal · up to a0487

No demonstrated issue blocks merging the updated passkey examples.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the retry cap from the passkey examples.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@yogeshchoudhary147
yogeshchoudhary147 merged commit 7b8b3ac into main Oct 26, 2026
22 checks passed
@yogeshchoudhary147
yogeshchoudhary147 deleted the docs/passkey-retry-cap branch October 26, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants