[mirror] microsoft/vscode#309332 Fix #32541: toggle block comment when cursor is inside comment#1621
Open
austindyoung wants to merge 7707 commits intomainfrom
Open
[mirror] microsoft/vscode#309332 Fix #32541: toggle block comment when cursor is inside comment#1621austindyoung wants to merge 7707 commits intomainfrom
austindyoung wants to merge 7707 commits intomainfrom
Conversation
…hat do not have any commits (microsoft#308752) * Sessions - isolation/branch picker should handle empty repositories that do not have any commits * Fix the tests
…rosoft#308608) - Add isClientBYOKEnabled() method to CopilotToken class - Update isBYOKEnabled to allow users with client_byok=1 token flag - Add github.copilot.clientByokEnabled context key for VS Code core model picker Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Without this, `this._controller.items.get(uri)` returns undefined... but the metadata is stored on the item so that is needed to resolve. FYI @mjbvz as an interesting quirk of the API.
* ghost: debt: migrate to CompletionsFetchService and remove dead code * ghost: propagate copilotAnnotations in convertStreamToApiChoices The v2 stream processor (convertStreamToApiChoices) was not setting copilotAnnotations on the returned APIChoice objects, despite tracking them in the CompletionAccumulator. This caused annotations (e.g., code citations) to be lost. Add accumulator.annotations.current to the createAPIChoice helper. * ghost: fix tests to mock ICompletionsFetchService for v2 After migrating to CompletionsFetchService, LiveOpenAIFetcher no longer calls ICompletionsFetcherService (via postRequest). Tests that mocked the old low-level fetcher with StaticFetcher were silently bypassed. Add StaticCompletionsFetchService adapter that bridges StaticFetcher responses into ICompletionsFetchService by parsing SSE bodies through jsonlStreamToCompletions. Wire it up in ghostText.test.ts and inlineCompletion.test.ts setupCompletion helpers.
…icrosoft#308726) * inline chat: bypass zone widget in hover mode, use direct sendRequest * address review: notebook config gate, faked timers in tests
* proper insider build increments * Update extensions/copilot/.esbuild.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ewrite In minified code, `async#method()` has no space between `async` and `#method`. The `#` naturally starts a new token, but when replaced with `$a`, the `$` is a valid identifier character — `async$a` fuses into a single identifier. This makes any `await` inside the method body a syntax error. Fix: when the character immediately before the `#` is an identifier character, prepend a space to the replacement text. Add 3 tests covering async, static async, and the readable variant.
…election and update related tests
…308600) Bumps [basic-ftp](https://github.com/patrickjuchli/basic-ftp) from 5.2.0 to 5.2.1. - [Release notes](https://github.com/patrickjuchli/basic-ftp/releases) - [Changelog](https://github.com/patrickjuchli/basic-ftp/blob/master/CHANGELOG.md) - [Commits](patrickjuchli/basic-ftp@v5.2.0...v5.2.1) --- updated-dependencies: - dependency-name: basic-ftp dependency-version: 5.2.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v5...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…icrosoft#308642) Make execution subagent model exp based. Also change default tool call limit
Chat queue/steer: fall back to normal send when no request is active When the queue or steer action is invoked but no request is in progress, send the message as a normal chat message instead of silently doing nothing. Relaxes the precondition and Alt+Enter keybinding so the actions remain reachable even after the session finishes, while keeping the Enter keybinding gated behind queuingActionsPresent so it doesn't conflict with the regular submit action. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
display this model may be experimental or in evaluation
…ith code block (microsoft#309336) * chat: fix body tag leaking into rendered markdown when content ends with code block When markdown content ends with a fenced code block, the closing backticks were immediately followed by </body> on the same line, so CommonMark didn't recognize the fence as closed. Add \n\n before </body> to ensure proper parsing. Add regression test. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: delete stale snapshots for regeneration The extra \n\n before </body> changes rendered HTML output slightly, so snapshot baselines need to be regenerated by CI. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: regenerate snapshot baselines for body tag fix Update snapshot files to reflect the extra \n\n before </body> in the markdown template, which adds trailing whitespace before the closing wrapper div in rendered HTML output. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…309308) * Chat - handle invalid URIs in extractCodeblockUrisFromText When an LLM explains code that uses vscode_codeblock_uri tags, the literal tag content may not be a valid URI, causing URI.parse to throw and crash the chat renderer. Add try-catch around URI.parse so invalid content gracefully returns undefined, which callers already handle by falling back to normal code block rendering. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix test: use content with backticks and colon to trigger URI scheme validation error Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…and branch updates (microsoft#309338)
* Prefer terminal presentation overrides in chat text * Hide sandbox wrapper from terminal command metadata
…icrosoft#309067) * agentHost: make 'open in vscode' button work for ssh/tunnel sessions * cleanup * fix tests
* Agents - remove "Update Branch" command * Remove more code
…ow (microsoft#309176) The `getLanguageModelCache` eviction check used `===` to compare the current entry count against `maxEntries`, which triggered eviction as soon as the cache reached its maximum size. At steady state the cache therefore held only `maxEntries - 1` entries instead of the intended `maxEntries`. Changing the condition to `>` ensures eviction only occurs when the count exceeds `maxEntries`, allowing the cache to retain the full number of intended entries. The same fix was applied to the HTML and CSS language servers which contain an identical copy of this file.
…crosoft#309408) Previously rejected NES entries now show a 👎 icon instead of no specific icon. Uses direct outcome assignment to avoid false warnings on the succeeded→previouslyRejected transition. Also registers the rebasedEdit (when present) with the rejection collector.
style: adjust padding for chatbar to improve layout consistency Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
…crosoft#309442) * style: update padding, margin, and border for sidebar elements in AI Customization Management * Update src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Bump version to 1.117.0 * npm i * wait to do engine version bump * Revert "wait to do engine version bump" This reverts commit 9db1c0f. * Add Copilot extension tests to Linux/Windows Electron integration test runs * Remove failing step that we moved to the main build --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…t-model-picker-overflow inlineChat: fix model picker overflow when selecting Auto
The Electron main process intermittently crashes during startup on the `[pango] FcInit` thread with a NULL pointer dereference in expat's XML string processing, triggered by fontconfig parsing `<include>` directives in fonts.conf via `XML_ExternalEntityParserCreate`. Set FONTCONFIG_FILE to a minimal config based on upstream fontconfig 2.15.0 fonts.conf.in with `<include>` directives removed and generic family aliases inlined. This avoids the external entity parser codepath entirely. A version check will fail the build once the runner ships expat >= 2.7.5, prompting removal of the workaround.
* Git - expose whether a repository is using GVFS * Make improvements for GVFS * Update extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionWorktreeServiceImpl.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionWorkspaceFolderServiceImpl.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix test compilation --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated mirror PR for DriftFence counterfactual telemetry.
Source PR: microsoft#309332
Source URL: microsoft#309332
Mirror branch: driftfence/mirror/pr-309332/latest
This PR is maintained by automation for telemetry and review links.