Skip to content

Speedup getting available datasets#156

Merged
hagenw merged 1 commit into
mainfrom
speedup-available
Jun 9, 2026
Merged

Speedup getting available datasets#156
hagenw merged 1 commit into
mainfrom
speedup-available

Conversation

@hagenw

@hagenw hagenw commented Jun 9, 2026

Copy link
Copy Markdown
Member

Use 10 workers to speed up audb.available().

@sourcery-ai

sourcery-ai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR speeds up building the list of available datasets for the Sphinx docs by invoking audb.available() with parallel workers, while preserving the existing filtering and sorting logic.

Sequence diagram for using parallel workers in audb.available during Sphinx build

sequenceDiagram
    participant SphinxBuilder as builder_inited
    participant audb as audb

    SphinxBuilder->>audb: available(only_latest=True, num_workers=10)
    audb-->>SphinxBuilder: DataFrame df
    SphinxBuilder->>SphinxBuilder: df.index.duplicated(keep="first") filter
    SphinxBuilder->>SphinxBuilder: df.sort_index()
Loading

File-Level Changes

Change Details Files
Speed up retrieval of available datasets during Sphinx build by enabling parallel workers in audb.available().
  • Pass num_workers=10 to audb.available() in the Sphinx builder_inited hook
  • Keep existing options (only_latest) and subsequent de-duplication and sorting of the resulting DataFrame unchanged
audbcards/sphinx/__init__.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Hardcoding num_workers=10 might not suit all environments; consider deriving the worker count from CPU resources (e.g., os.cpu_count() capped at a reasonable maximum) or making it configurable.
  • It may be worth handling the case where the environment running Sphinx (e.g. CI or low-resource machines) cannot support the chosen worker count, either by catching errors or falling back to a single-worker call.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Hardcoding `num_workers=10` might not suit all environments; consider deriving the worker count from CPU resources (e.g., `os.cpu_count()` capped at a reasonable maximum) or making it configurable.
- It may be worth handling the case where the environment running Sphinx (e.g. CI or low-resource machines) cannot support the chosen worker count, either by catching errors or falling back to a single-worker call.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw

hagenw commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

We are using threads here to wait for network traffic. This will even provide a speed up on a singel CPU and will not harm.

@hagenw hagenw merged commit 6724132 into main Jun 9, 2026
13 checks passed
@hagenw hagenw deleted the speedup-available branch June 9, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant