Speedup getting available datasets#156
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR speeds up building the list of available datasets for the Sphinx docs by invoking audb.available() with parallel workers, while preserving the existing filtering and sorting logic. Sequence diagram for using parallel workers in audb.available during Sphinx buildsequenceDiagram
participant SphinxBuilder as builder_inited
participant audb as audb
SphinxBuilder->>audb: available(only_latest=True, num_workers=10)
audb-->>SphinxBuilder: DataFrame df
SphinxBuilder->>SphinxBuilder: df.index.duplicated(keep="first") filter
SphinxBuilder->>SphinxBuilder: df.sort_index()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Hardcoding
num_workers=10might not suit all environments; consider deriving the worker count from CPU resources (e.g.,os.cpu_count()capped at a reasonable maximum) or making it configurable. - It may be worth handling the case where the environment running Sphinx (e.g. CI or low-resource machines) cannot support the chosen worker count, either by catching errors or falling back to a single-worker call.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Hardcoding `num_workers=10` might not suit all environments; consider deriving the worker count from CPU resources (e.g., `os.cpu_count()` capped at a reasonable maximum) or making it configurable.
- It may be worth handling the case where the environment running Sphinx (e.g. CI or low-resource machines) cannot support the chosen worker count, either by catching errors or falling back to a single-worker call.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
|
We are using threads here to wait for network traffic. This will even provide a speed up on a singel CPU and will not harm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use 10 workers to speed up
audb.available().