Skip to content

fix(docs): wire correct icons to docs landing cards (Closes #5699) - #5702

Open
waterWang wants to merge 1 commit into
asyncapi:masterfrom
waterWang:fix/docs-card-icons-5699
Open

fix(docs): wire correct icons to docs landing cards (Closes #5699)#5702
waterWang wants to merge 1 commit into
asyncapi:masterfrom
waterWang:fix/docs-card-icons-5699

Conversation

@waterWang

@waterWang waterWang commented Aug 14, 2026

Copy link
Copy Markdown

Summary

Fixes #5699 — Docs / Community card icons in the landing page Header section use icons that don't match their sections.

Changes

  1. components/data/buckets.ts

    • Tools bucket: was using IconUseCases (pen/quill — reads as "writing/authoring") → now uses IconTools (wrench/tools metaphor matching the AsyncAPI tools ecosystem docs).
    • Specification Explorer bucket: was using IconExplorer (sitemap node with plus sign — reads as "add a node") → now uses IconLoupe (magnifier, matching the "explore the spec" intent).
    • Removed the now-unused IconExplorer import.
  2. components/icons/Migration.tsx

    • The component exported itself as IconUsers while living in Migration.tsx, which misleads any consumer importing it as IconMigration and shadows the real Users icon's role. Renamed the export to IconMigration to match the file name and its actual migration icon content.

Verification

  • components/icons/Tools.tsx and components/icons/Loupe.tsx already existed (verified via repo tree) — no new icons needed to be authored.
  • buckets.ts import list now includes IconTools and IconLoupe, and no longer references IconExplorer/IconUseCases in the card mappings.
  • The real Users icon (components/icons/Users.tsx) still exports IconUsers and is untouched — Community card remains correct.

Summary by CodeRabbit

  • Bug Fixes
    • Updated category icons to better represent Tools and Explorer.
    • Corrected the migration icon’s label while preserving its appearance.

@netlify

netlify Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f5d9a28
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/6a7eb9e7714e400007cb3afd
😎 Deploy Preview https://deploy-preview-5702--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5d6bc635-5e80-47bb-b1a6-19552dd099dc

📥 Commits

Reviewing files that changed from the base of the PR and between 7db4e19 and f5d9a28.

📒 Files selected for processing (2)
  • components/data/buckets.ts
  • components/icons/Migration.tsx

📝 Walkthrough

Walkthrough

The change renames the migration icon component and updates the tools and Explorer bucket mappings to use IconTools and IconLoupe.

Changes

Icon mapping updates

Layer / File(s) Summary
Rename migration icon component
components/icons/Migration.tsx
The default-exported component is renamed from IconUsers to IconMigration. Its props and SVG output remain unchanged.
Update bucket icon references
components/data/buckets.ts
The tools bucket uses IconTools, and the Explorer bucket uses IconLoupe. Their imports are updated accordingly.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f5d9a

This PR makes localized documentation icon and export-name corrections without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: akshatnema

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes wiring the correct icons to the documentation landing cards, which is the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: dependency version conflict. Check your lock file or package.json.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@asyncapi-bot

Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-5702--asyncapi-website.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Be Triaged

Development

Successfully merging this pull request may close these issues.

[BUG] Docs / Community Card Icons in landing page Header section cards use icons that don't match their sections

2 participants