fix: correct displayName type in Sneak Peek example - #5662
fix: correct displayName type in Sneak Peek example#5662swarupasaroogumma wants to merge 3 commits into
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe PR corrects the rendered AsyncAPI ChangesSchema and runtime dependency updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
🔧 Fix failing CI
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
66-66: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAvoid unconstrained minor-version drift for newly added dependencies.
Both dependencies use caret ranges, allowing automatic minor-version updates. Pin exact versions or use conservative ranges, and verify the committed lockfile resolves the intended React-compatible versions.
package.json#L66-L66: constrain@xyflow/reactinstead of using^12.11.2.package.json#L102-L102: constrainreact-i18nextinstead of using^16.6.5.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 66, Constrain the newly added `@xyflow/react` dependency in package.json at lines 66-66 and react-i18next at lines 102-102 by replacing caret ranges with exact versions or conservative ranges; update and verify the committed lockfile resolves the intended React-compatible versions.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Line 66: Constrain the newly added `@xyflow/react` dependency in package.json at
lines 66-66 and react-i18next at lines 102-102 by replacing caret ranges with
exact versions or conservative ranges; update and verify the committed lockfile
resolves the intended React-compatible versions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 873f9b03-bbd0-49d1-bf8c-8b082f328883
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
components/SneakPeek.tsxpackage.json
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5662--asyncapi-website.netlify.app/ |



Description
This PR updates the
displayNamefield type in the AsyncAPI document shown in the Sneak Peek example.Before:
After:
The AsyncAPI document example represents
displayNameas anobject, while the generated TypeScript and documentation preview both represent it as astring. This change makes the three previews consistent.Type of change
Testing
Summary by CodeRabbit
displayNamepayload property in AsyncAPI document previews.