fix: allow excess protocol-specific fields on Binding (issue #735) - #1228
Open
tzh476 wants to merge 2 commits into
Open
fix: allow excess protocol-specific fields on Binding (issue #735)#1228tzh476 wants to merge 2 commits into
tzh476 wants to merge 2 commits into
Conversation
…#735) Change-Id: I2b53925665dd23e273e90fe42eb8ee90b4342907
tzh476
requested review from
AayushSaini101,
asyncapi-bot-eve,
magicmatatjahu and
princerajpoot20
as code owners
August 23, 2026 08:35
🦋 Changeset detectedLatest commit: e365630 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Change-Id: Ie4f192783e7f7fb3e533f058974c6a5bb51a3eb8
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #735.
Adds a
[propName: string]: any;index signature to the v2 and v3Bindingspec-type interfaces (per the maintainer-approved approach), so protocol-specific binding fields such asclientIdare accessible without a cast.Binding.Verified: tsc --noEmit clean; v2 bindings 9/9; v3 bindings 8/8.