This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Make is_shadowing_variable() failable#615
Merged
Merged
Conversation
djc
reviewed
Jan 31, 2022
Comment on lines
+820
to
+826
| Target::Tuple(_, targets) => targets | ||
| .iter() | ||
| .any(|target| self.is_shadowing_variable(target)), | ||
| .find_map(|target| match self.is_shadowing_variable(target) { | ||
| Ok(false) => None, | ||
| outcome => Some(outcome), | ||
| }) | ||
| .unwrap_or(Ok(false)), |
Collaborator
There was a problem hiding this comment.
Transforming from Ok(false) to None, then back to Ok(false) doesn't seem like a great way to do this. At this point it might be better to just use a for-loop?
Member
Author
There was a problem hiding this comment.
Yeah, a loop looks better. Changed.
| outcome => Some(outcome), | ||
| }) | ||
| .unwrap_or(Ok(false)), | ||
| _ => Err("Cannot have literals on the left-hand-side of an assignment.".into()), |
Collaborator
There was a problem hiding this comment.
Probably rewrite this as "literals are not allowed on the left-hand side of an assignment" (no capital, no period).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #612.