This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Limit nested filters to avoid stack overflow 2#1072
Closed
manunio wants to merge 2 commits into
Closed
Conversation
GuillaumeGomez
approved these changes
Jun 23, 2024
Collaborator
|
Looks good to me, thanks! |
djc
reviewed
Jun 29, 2024
| opt(|i| Expr::arguments(i, level, false)), | ||
| ))(i)?; | ||
| Ok((i, (fname, args))) | ||
| fn filter<'a>(i: &'a str, level: &mut Level) -> ParseResult<'a, (&'a str, Option<Vec<Expr<'a>>>)> { |
Collaborator
There was a problem hiding this comment.
Level is Copy, why break the convention of passing it by value here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66029.
This pr includes all the work at #979 done by @djc as well as updated ui test.
For ui test: I think previous input for filter-recursion ui test was not right as it
was not triggering error for recursion itself, for example: