Skip to content

Switch back to std::string in patch to fix a use-after-free #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kenzzer merged 1 commit into from
Jan 1, 2026
Merged

Switch back to std::string in patch to fix a use-after-free #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions patches/0002-Write-FUNC-records-instead-of-PUBLIC-for-ELF-symbols.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ index 70d50f89..f21460bf 100644
iterator->shndx != SHN_UNDEF) {
- auto ext = std::make_unique<Module::Extern>(iterator->value);
- ext->name = SymbolString(iterator->name_offset, strings);
+ auto name = SymbolString(iterator->name_offset, strings);
+ std::string name = SymbolString(iterator->name_offset, strings);
#if !defined(__ANDROID__) // Android NDK doesn't provide abi::__cxa_demangle.
int status = 0;
char* demangled =
- abi::__cxa_demangle(ext->name.c_str(), nullptr, nullptr, &status);
+ abi::__cxa_demangle(name, nullptr, nullptr, &status);
+ abi::__cxa_demangle(name.c_str(), nullptr, nullptr, &status);
if (demangled) {
if (status == 0)
- ext->name = demangled;
Expand Down