Skip to content

Fix symbol uploads #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kenzzer merged 3 commits into from
Nov 30, 2025
Merged

Fix symbol uploads #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f1d391
Fix parameter order
adriansmares Nov 30, 2025
8e56bdd
Do not preserve address offset
adriansmares Nov 30, 2025
78d921c
Do not pass explicit symbol ID
adriansmares Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extension/extension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,17 +565,17 @@ class UploadThread: public IThread
};

std::ostringstream outputStream;
google_breakpad::DumpOptions options(ALL_SYMBOL_DATA, true, true, true);
google_breakpad::DumpOptions options(ALL_SYMBOL_DATA, true, true, false);

{
StderrInhibitor stdrrInhibitor;

if (!WriteSymbolFile(debugFile, debugFile, debugFile, "Linux", debug_dirs, options, outputStream)) {
if (!WriteSymbolFile(debugFile, debugFile, "Linux", "", debug_dirs, options, outputStream)) {
outputStream.str("");
outputStream.clear();

// Try again without debug dirs.
if (!WriteSymbolFile(debugFile, debugFile, debugFile, "Linux", {}, options, outputStream)) {
if (!WriteSymbolFile(debugFile, debugFile, "Linux", "", {}, options, outputStream)) {
if (log) fprintf(log, "Failed to process symbol file\n");
if (log) fflush(log);
return false;
Expand Down