docs: fix shape of expected array in LOO docstring#96
Merged
sethaxen merged 1 commit intoarviz-devs:mainfrom Apr 21, 2026
Merged
docs: fix shape of expected array in LOO docstring#96sethaxen merged 1 commit intoarviz-devs:mainfrom
sethaxen merged 1 commit intoarviz-devs:mainfrom
Conversation
|
Just came across this yesterday as well 🙂 |
sethaxen
approved these changes
Apr 21, 2026
Member
sethaxen
left a comment
There was a problem hiding this comment.
Good catch, thanks! Yes, I would say this warrants a patch release.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 16 16
Lines 936 936
=======================================
Hits 911 911
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Actually, I'll get it in the same patch release as #95, so no need to bump it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring has the dimensions in the wrong way round. (PSIS is correct :) https://julia.arviz.org/PSIS/stable/api/#PSIS.psis)
Given that this is just a docs change I'm not sure if you'd like a patch bump, happy to do so if desired.