[Node] Custom ID inflected from schema.#4
Closed
alloy wants to merge 8 commits into
Closed
Conversation
20 tasks
alloy
commented
Sep 8, 2017
| selections: flattenArray(node.selections), | ||
| }; | ||
| }, | ||
| constructor(idField: string) { |
Author
There was a problem hiding this comment.
Rather than having to pass the ‘Node ID’ field in, I’m wondering if I can revert this change and instead encode the ‘Node ID’ into the metadata of the selection 🤔
alloy
commented
Sep 8, 2017
| } | ||
| `.replace(/^\s{8}/gm, '').trim()); | ||
| }); | ||
| }); |
Author
There was a problem hiding this comment.
Should probably refactor this to work similar to the other fixture based tests.
|
Danger run resulted in 1 warning; to find out more, see the checks page. Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Relay v1.3.0 patched to inflect the ID from our schema, which in our case is
__id.Now that this is merged into Emission master artsy/emission#616, we’ll start extensive testing and I’ll start cleaning up the commits in this branch, see if things can be improved, and send an upstream PR.
In Emission we’re actually using a slightly modified version of this branch, which:
QLPrinter. Need to research if this is a fluke or a legitimate Relay bug.