[Toolchain] Update Relay to support new TypeScript compiler option#522
Merged
damassi merged 5 commits intoartsy:masterfrom Feb 14, 2018
Merged
[Toolchain] Update Relay to support new TypeScript compiler option#522damassi merged 5 commits intoartsy:masterfrom
damassi merged 5 commits intoartsy:masterfrom
Conversation
damassi
commented
Feb 14, 2018
| package-lock.json | ||
| reaction-force.js | ||
| reaction-force.js.map | ||
| yarn-error.log No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
just alpha and cleanup
damassi
commented
Feb 14, 2018
| "relay-compiler": "https://github.com/alloy/relay/releases/download/v1.5.0-plugin.2/relay-compiler-1.5.0-plugin.2.tgz", | ||
| "relay-runtime": "https://github.com/alloy/relay/releases/download/v1.5.0-plugin.2/relay-runtime-1.5.0-plugin.2.tgz", | ||
| "react-relay": "https://github.com/alloy/relay/releases/download/v1.5.0-plugin.2/react-relay-1.5.0-plugin.2.tgz" | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
I figured it would be clearest to explicitly resolve all of our patches here similar to the most recent example, and then update / remove when ready.
Contributor
|
Nice 👌 You may wanna update to the latest code, as per this example artsy/emission#985, but otherwise I’m good with this as-is 👍 |
Contributor
|
Btw, will you do another PR where the emitted types will be used? |
Contributor
Author
|
@alloy - you mean in terms of |
Contributor
|
Yup, that part. Sounds good 👍 |
Contributor
|
Merge when 💚 ! |
This was referenced Feb 15, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on work completed in Emission:
Afterwards you can use the regular script again: