Skip to content

[Toolchain] Update Relay to support new TypeScript compiler option#522

Merged
damassi merged 5 commits intoartsy:masterfrom
damassi:update-relay-to-latest
Feb 14, 2018
Merged

[Toolchain] Update Relay to support new TypeScript compiler option#522
damassi merged 5 commits intoartsy:masterfrom
damassi:update-relay-to-latest

Conversation

@damassi
Copy link
Copy Markdown
Contributor

@damassi damassi commented Feb 14, 2018

Based on work completed in Emission:

⚠️ If you already had Reaction checked out before, be sure to delete / rebuild all previous artifacts:

$ find . -name __generated__ | xargs rm -rf
$ yarn relay

Afterwards you can use the regular script again:

$ yarn start

Comment thread .gitignore
package-lock.json
reaction-force.js
reaction-force.js.map
yarn-error.log No newline at end of file
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just alpha and cleanup

Comment thread package.json
"relay-compiler": "https://github.com/alloy/relay/releases/download/v1.5.0-plugin.2/relay-compiler-1.5.0-plugin.2.tgz",
"relay-runtime": "https://github.com/alloy/relay/releases/download/v1.5.0-plugin.2/relay-runtime-1.5.0-plugin.2.tgz",
"react-relay": "https://github.com/alloy/relay/releases/download/v1.5.0-plugin.2/react-relay-1.5.0-plugin.2.tgz"
},
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it would be clearest to explicitly resolve all of our patches here similar to the most recent example, and then update / remove when ready.

@alloy
Copy link
Copy Markdown
Contributor

alloy commented Feb 14, 2018

Nice 👌 You may wanna update to the latest code, as per this example artsy/emission#985, but otherwise I’m good with this as-is 👍

@alloy
Copy link
Copy Markdown
Contributor

alloy commented Feb 14, 2018

Btw, will you do another PR where the emitted types will be used?

@damassi
Copy link
Copy Markdown
Contributor Author

damassi commented Feb 14, 2018

@alloy - you mean in terms of interface Props { artist: TypescriptEmittedArtistProps }? If so then yes, that should be in another PR. I'll add that to my sprint backlog.

@alloy
Copy link
Copy Markdown
Contributor

alloy commented Feb 14, 2018

Yup, that part. Sounds good 👍

@alloy
Copy link
Copy Markdown
Contributor

alloy commented Feb 14, 2018

Merge when 💚 !

@damassi damassi merged commit ac04e90 into artsy:master Feb 14, 2018
@damassi damassi deleted the update-relay-to-latest branch February 14, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants