Skip to content

@damassi => Add semantic-release #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damassi merged 8 commits into from
Feb 16, 2018
Merged

@damassi => Add semantic-release #521

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0444c11
add semantic release package, add deploy script to circle yml
eessex Feb 14, 2018
6cb2b8d
remove npm ci scripts
eessex Feb 14, 2018
954ec94
update readme
eessex Feb 15, 2018
c6fc1a1
add release rules based on ember standard
eessex Feb 16, 2018
44e6fa9
[DOC semantic-release] update docs to reflect ember changelog convent…
eessex Feb 16, 2018
820c1b9
merge conflicts
eessex Feb 16, 2018
f0056e0
add patch tag, update readme
eessex Feb 16, 2018
ca470de
Merge branch 'master' into semantic-release
eessex Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ test:
- yarn test -- --runInBand

deployment:
release:
branch: master
- yarn run semantic-release
Copy link
Copy Markdown
Contributor

@damassi damassi Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some legacy stuff around here that relates to legacy deployment process. Once we've verified that this works we should make sure to remove that and update README.

Copy link
Copy Markdown
Contributor Author

@eessex eessex Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure!

demo:
branch: master
commands:
Expand Down
8 changes: 5 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@artsy/reaction-force",
"version": "0.21.0",
"version": "0.0.0-development",
Copy link
Copy Markdown
Contributor

@damassi damassi Feb 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this account for existing packages that have already been published to NPM? Does it determine from there that the current release is 0.23.1 and update accordingly?

Copy link
Copy Markdown
Contributor Author

@eessex eessex Feb 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should fetch the version number from the existing package on npm. This version number is a placeholder and will always read 0.0.0.

Copy link
Copy Markdown
Contributor Author

@eessex eessex Feb 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging, the build on Circle will log which commits trigger changes, as well as the new version number.

Copy link
Copy Markdown
Contributor

@damassi damassi Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, just wanted to double check 👍

Copy link
Copy Markdown
Contributor Author

@eessex eessex Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also wanted to note it looks like this version number is being overwritten when I push a commit, but don't see where this is being set.

"description": "Force’s React Components",
"main": "dist/index.js",
"repository": "https://github.com/artsy/reaction.git",
Expand Down Expand Up @@ -41,7 +41,8 @@
"test": "node verify-node-version.js && jest",
"test:watch": "jest --watch --runInBand",
"type-check": "tsc --noEmit --pretty",
"watch": "gulp watch"
"watch": "gulp watch",
"semantic-release": "semantic-release"
},
"devDependencies": {
"@playlyfe/gql": "^2.3.2",
Expand Down Expand Up @@ -100,7 +101,8 @@
"typescript": "^2.6.2",
"typescript-babel-jest": "^1.0.3",
"typescript-styled-plugin": "^0.1.2",
"webpack-merge": "^4.1.0"
"webpack-merge": "^4.1.0",
"semantic-release": "^12.4.1"
},
"dependencies": {
"history": "^4.6.1",
Expand Down