This repository was archived by the owner on Mar 12, 2020. It is now read-only.
Closed
Conversation
They made the warning about fields starting with a dunderscore into real errors, so simply disabling that code after installation.
alloy
commented
Dec 26, 2017
| "homepage": "https://github.com/artsy/emission#readme", | ||
| "files": ["index.js", "data", "lib"], | ||
| "resolutions": { | ||
| "graphql": "^0.12.3", |
Contributor
Author
There was a problem hiding this comment.
Some of our dev deps pull in an older version, which messes with the tree we want, so just overriding it for now.
alloy
commented
Dec 26, 2017
| + // // as it may be removed at any time. | ||
| + // name !== '__configs__') { | ||
| + // return new _GraphQLError.GraphQLError('Name "' + name + '" must not begin with "__", which is reserved by ' + 'GraphQL introspection.', node); | ||
| + // } |
Contributor
Author
There was a problem hiding this comment.
graphql-js made this a hard error now 😢 Just disabling it for now.
Generated by 🚫 dangerJS |
Contributor
|
We should try make a concerted effort to deal with all these: |
Contributor
Author
|
Closing in favour of #982 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses my updated Relay custom Node ID patches, which brings in the latest Relay. While it seems to work well, I’m not sure if we should merge it in this repo at this time just before v4. Let’s wait for now, but feel free to give it a spin!