Skip to content

Use guaranteeCase in CircuitBreaker instead of addSuppressed#3796

Merged
kyay10 merged 1 commit intomainfrom
kyay10/circuitBreaker-addSuppressed
Dec 14, 2025
Merged

Use guaranteeCase in CircuitBreaker instead of addSuppressed#3796
kyay10 merged 1 commit intomainfrom
kyay10/circuitBreaker-addSuppressed

Conversation

@kyay10
Copy link
Copy Markdown
Collaborator

@kyay10 kyay10 commented Nov 29, 2025

Part of the effort to unify addSuppressed usages, this delegates to guaranteeCase; as a nice bonus, the code is cleaner!

@kyay10 kyay10 requested review from nomisRev and serras November 29, 2025 22:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 29, 2025

Kover Report

File Coverage [91.56%]
arrow-libs/resilience/arrow-resilience/src/commonMain/kotlin/arrow/resilience/CircuitBreaker.kt 91.56%
Total Project Coverage 47.12%

Comment thread arrow-libs/resilience/arrow-resilience/build.gradle.kts Outdated
@serras
Copy link
Copy Markdown
Member

serras commented Dec 14, 2025

@kyay10 sorry for all the back and forth. I thought splitting arrow-exception-utils would solve the dependency on arrow-fx-coroutines problem, but it doesn't. I think adding that dependency to arrow-resilience is not that bad, and that allows us to unify behavior everywhere. So I would say, let's go with this approach!

@serras serras force-pushed the kyay10/circuitBreaker-addSuppressed branch from 01cf07e to 123d79e Compare December 14, 2025 08:04
@serras
Copy link
Copy Markdown
Member

serras commented Dec 14, 2025

@kyay10 I've rebased the branch on the latest main. Feel free to merge if the rebased version is OK for you.

@kyay10 kyay10 merged commit 84c02fa into main Dec 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants