Remove the 'all-priority-classes' flag from armadactl commands - #5135
Open
JamesMurkin wants to merge 2 commits into
Open
Remove the 'all-priority-classes' flag from armadactl commands#5135JamesMurkin wants to merge 2 commits into
JamesMurkin wants to merge 2 commits into
Conversation
For cancel/preempt queue/node/executor, we now simply default to all priority classes unless a priority class filter is provided The 'all-priority-classes' was cumbersome and users typically always wanted 'all-priority-classes' Making it default aligns the command with user expectation and makes it easier to use, while keeping the optional filter of priority classes if users need it Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
JamesMurkin
marked this pull request as ready for review
August 27, 2026 11:21
Contributor
Greptile SummaryThe PR removes the
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| cmd/armadactl/cmd/cancel.go | Removes the explicit all-priority-classes flag and defaults empty priority-class selections to all classes for cancellation commands. |
| cmd/armadactl/cmd/cancel_test.go | Exercises real cancellation command handlers and verifies their arguments at the API boundary. |
| cmd/armadactl/cmd/preempt.go | Applies the same default-all priority-class behavior and injectable command construction to preemption commands. |
| cmd/armadactl/cmd/preempt_test.go | Adds shared API-boundary fakes and verifies real preemption command parsing and request construction. |
Reviews (2): Last reviewed commit: "More robust tests" | Re-trigger Greptile
Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
eleanorpratt
approved these changes
Aug 27, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For cancel/preempt queue/node/executor, we now simply default to all priority classes unless a priority class filter is provided
The 'all-priority-classes' was cumbersome and users typically always wanted 'all-priority-classes'
Making it default aligns the command with user expectation and makes it easier to use, while keeping the optional filter of priority classes if users need it
I've also reworked the tests - so we don't override RunE etc and let that use the real production code