Skip to content

added myself to mergify for reviewing, I missed a line the first time… #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sarhiri wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

added myself to mergify for reviewing, I missed a line the first time… #5126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
431dabd
added myself to mergify for reviewing, I missed a line the first time…
sarhiri Aug 20, 2026
b92d66b
Merge branch 'master' into sarhiri-reviewer-status
sarhiri Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .mergify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ pull_request_rules:
- "#approved-reviews-by>=2"
- and:
- "#approved-reviews-by>=1"
- "author~=^(d80tb7|dave[-]gantenbein|dejanzele|eleanorpratt|geaere|JamesMurkin|mauriceyap|masipauskas|MustafaI|zuqq|richscott|robertdavidsmith|samclark|suprjinx|EnricoMi|nikola-jokic|dslear|d2burkhalter|ianhockett|Sigele|williamvega|tgucks|YHines004|j8169)$"
- "author~=^(d80tb7|dave[-]gantenbein|dejanzele|eleanorpratt|geaere|JamesMurkin|mauriceyap|masipauskas|MustafaI|zuqq|richscott|robertdavidsmith|samclark|suprjinx|EnricoMi|nikola-jokic|dslear|d2burkhalter|ianhockett|Sigele|williamvega|tgucks|YHines004|j8169|sarhiri)$"

@greptile-apps greptile-apps Bot Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Maintainer roster is out of sync

Adding sarhiri to the one-approval Mergify allowlist without adding the account to MAINTAINERS.md leaves the documented roster inconsistent with the elevated review privilege, making maintainer status harder to audit.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

title: Two approvals required, or one if author is a frontend or Armada maintainer.

- name: Require approval from Armada maintainers
Expand Down
Loading