Skip to content

Add cj87holler to Mergify maintainer lists - #5125

Open
cj87holler wants to merge 2 commits into
armadaproject:masterfrom
cj87holler:add-cj87holler-maintainer
Open

Add cj87holler to Mergify maintainer lists#5125
cj87holler wants to merge 2 commits into
armadaproject:masterfrom
cj87holler:add-cj87holler-maintainer

Conversation

@cj87holler

Copy link
Copy Markdown

What type of PR is this? Chore - repository configuration

What this PR does / why we need it: Adds 'cj87holler' to maintainer allow-list in both .mergify.yml and pull_request_rules, so that approvals from thsi account satisfy the single-approval condition in the same way as existing maintainers. No rule logic is changed - this is a two-line addition to the existing author~=^(...) regexes.

Which issue(s) this PR fixes

N/A

Special notes for your reviewer

I'm joining as a maintainer and this is my first PR to the repo. I will mainly be collaborating with @sarhiri on documentation and website changes.

Signed-off-by: cj87holler <17093384+cj87holler@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates Mergify’s approval conditions so pull requests authored by cj87holler qualify for the existing single-approval maintainer path.

  • Adds cj87holler to both maintainer author allow-list expressions.
  • Leaves approval thresholds and other rule logic unchanged.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.mergify.yml Adds the new maintainer account consistently to both applicable anchored author allow-lists without changing rule structure.

Reviews (2): Last reviewed commit: "Merge branch 'master' into add-cj87holle..." | Re-trigger Greptile

Comment thread .mergify.yml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added GH handle to approvers/maintainers

@dave-gantenbein
dave-gantenbein enabled auto-merge (squash) August 20, 2026 15:36
@cj87holler

Copy link
Copy Markdown
Author

Thanks @sarhiri and @dave-gantenbein for the reviews. Flagging that this is blocked by a bootstrap issue rather than anything in the diff: Mergify evaluates .mergify.yml from the base branch, so this PR can't satisfy the maintainer-author condition it's adding. The #approved-reviews-by>=2 branch also isn't met, it looks like only one of the two approvals is counting, since Mergify only counts reviewers with write access.

@mauriceyap could you add an approval? That should get to two counting approvals and turn the check green without needing an override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants