Skip to content

Add auth-fake-executor profile for local development - #5118

Open
nikola-jokic wants to merge 3 commits into
masterfrom
auth-fake-executor-profile
Open

Add auth-fake-executor profile for local development#5118
nikola-jokic wants to merge 3 commits into
masterfrom
auth-fake-executor-profile

Conversation

@nikola-jokic

Copy link
Copy Markdown
Contributor

What type of PR is this?

Dev experience

What this PR does / why we need it

makes it easier to test job transformations without running executor while still having auth logic.

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds an authenticated local-development profile using the fake executor, including standard and Delve variants.

  • Recognizes auth-fake-executor during profile selection and enables the authentication dependencies.
  • Adds matching standard and DAP Procfiles.
  • Documents the new profile in the local-development guides.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; both previously reported issues are fixed by adding the DAP Procfile and including the new selector in the conflict warning.

Important Files Changed

Filename Overview
magefiles/dev.go Adds the new profile selector, includes it in conflict diagnostics, enables auth dependencies, and waits for Keycloak.
_local/procfiles/auth-fake-executor.Procfile Defines the authenticated local stack with the fake executor and profile-appropriate service configurations.
_local/procfiles/auth-fake-executor-dap.Procfile Supplies the previously missing Delve variant using the repository's established DAP process and port conventions.
docs/developer_guide.md Documents profile selection, purpose, and the new Procfile.
_local/README.md Updates the local-stack Procfile inventory to include the new profile.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[mage dev:up auth-fake-executor] --> B[Select auth-fake-executor Procfile]
  B --> C[Enable auth compose profile]
  C --> D[Start Keycloak dependencies]
  D --> E[Start authenticated Armada services]
  E --> F[Run fake executor without Kubernetes]
  A2[mage dev:up auth-fake-executor -dap] --> B2[Select auth-fake-executor-dap Procfile]
  B2 --> C
Loading

Reviews (5): Last reviewed commit: "fix msg" | Re-trigger Greptile

Comment thread magefiles/dev.go
Comment thread magefiles/dev.go Outdated
@nikola-jokic nikola-jokic changed the title Add auth-fake-executor profile for OIDC testing without Kubernetes Add auth-fake-executor profile for local development Aug 14, 2026
@nikola-jokic
nikola-jokic force-pushed the auth-fake-executor-profile branch 3 times, most recently from a905c3b to 4fb6203 Compare August 18, 2026 10:20
@nikola-jokic
nikola-jokic force-pushed the auth-fake-executor-profile branch from 4fb6203 to dcb2f29 Compare August 21, 2026 13:46

@d2burkhalter d2burkhalter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify

mergify Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants