Add RetryPolicy CRUD service and queue attachment validation

[dejanzele]

Implements the RetryPolicyService whose proto was defined in #4998: create, get, list, update, and delete for retry policies, backed by a Postgres repository. Adds create_retry_policy, update_retry_policy, and delete_retry_policy permissions and maps them in the local development server configs. Creating a policy that already exists replaces it, the same as create queue, so a pipeline that creates policies can be re-run. Updating one that does not exist still returns NotFound.

Queue attachments are stored relationally rather than inside the serialized queue definition. Migration 035 adds the retry_policy table together with a queue_retry_policy join table, where each row records the position its policy held in the submitted list so that a queue reads its policies back in the order they were given. The queue repository rewrites those rows on every queue write and composes RetryPolicies from them on every read, so the serialized definition never carries the names.

A foreign key on policy_name is what prevents a queue referencing a policy that does not exist. A queue write also looks the names up first, so the error can say which ones are missing, returned as InvalidArgument. In the narrow case where a policy is deleted between that lookup and the write, the foreign key rejects the write with a less specific message. Deleting a policy removes its attachment rows and then the policy itself, returning the queues it detached for the service to log. The migration names that constraint explicitly because the repository matches on it.

Both tables are queried through sqlc, generated into internal/server/queryapi/database, matching the pattern the scheduler already uses. The queue table's own statements are unchanged.

Independent of #5047 and #5048, any merge order works. Two notes on the seams: the RetryPolicies field on the client queue type also appears in #5048 as an identical hunk, since both PRs need it to compile on their own, and it merges cleanly from either direction. The retry policy service tests define their own gRPC status helper, which can switch to the shared one from #5047 once both are in.

Replaces #5000, which carried all of this plus the client and armadactl work in one PR.

[greptile-apps]

Greptile Summary

Adds a Postgres-backed retry-policy CRUD service and relational queue-policy attachments.

• Registers the retry-policy gRPC and REST services with create, update, and delete authorization.
• Adds retry-policy and ordered queue-attachment tables, generated sqlc queries, repositories, validation, and tests.
• Validates queue attachments and translates unknown policy references into InvalidArgument.

Confidence Score: 5/5

The PR appears safe to merge because no additional blocking failure eligible for this follow-up review remains.

No blocking failure remains beyond issues already covered by previous review threads.

Important Files Changed

Filename	Overview
internal/server/retrypolicy/repository.go	Implements transactional Postgres CRUD for serialized retry policies and attachment cleanup on deletion.
internal/server/retrypolicy/service.go	Implements authorized and validated retry-policy CRUD RPC behavior with gRPC status translation.
internal/server/queue/queue_repository.go	Persists ordered retry-policy attachments relationally and reconstructs them on queue reads.
internal/lookout/schema/migrations/035_create_retry_policy.sql	Adds retry-policy storage and the ordered queue-policy join table with cascading foreign keys.
internal/server/server.go	Wires the retry-policy repository and service into the API server.
cmd/server/main.go	Registers the retry-policy REST gateway handler.
_local/server/config.yaml	Maps retry-policy mutation permissions for the local unauthenticated configuration.
_local/server/config-auth.yaml	Maps retry-policy mutation permissions to local administrators.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Client[Client] --> Service[RetryPolicy / Queue services]
  Service --> Repository[Postgres repositories]
  Repository --> Policy[(retry_policy)]
  Repository --> Attachment[(queue_retry_policy)]
  Attachment --> Queue[(queue)]
  Attachment --> Policy

Loading

_{Reviews (31): Last reviewed commit: "Add RetryPolicy CRUD service and queue a..." | Re-trigger Greptile}

[datadog-armadaproject]

⚠️ Warnings

🚦 1 Pipeline job failed

CI | test / SQLC Generated Files Up To Date     

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e500da4 | Docs | Datadog PR Page | Give us feedback!}

[dejanzele]

@greptileai

[dejanzele]

@greptileai please analyze now with the new database approach

[dejanzele]

@greptileai

[dejanzele]

@greptileai

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request