GetSatelliteSchemaの戻り値で各種descriptionを含めるように変更#248
Open
shunsuke-shimomura wants to merge 2 commits intomainfrom
Open
GetSatelliteSchemaの戻り値で各種descriptionを含めるように変更#248shunsuke-shimomura wants to merge 2 commits intomainfrom
shunsuke-shimomura wants to merge 2 commits intomainfrom
Conversation
shunsuke-shimomura
force-pushed
the
tco-tmiv-description
branch
from
93c51cb to
9daa3cd
Compare
Member
|
tmtc-c2a 側の GetSatelliteSchema で各種 description を返したいというモチベーションには大いに同意で、その API の用途に鑑みて当然返されるべきと思います。 しかし、現状 の gaia-ccsds-c2a の schema ではテレメ・コマンドのビット列の表現に関することだけを保持する方針の設計になっており、こちら側に description 等のメタデータを持たせていいかどうかは悩ましいです。 |
KOBA789 (KOBA789)
requested changes
Jun 12, 2024
Member
KOBA789 (KOBA789)
left a comment
KOBA789 (KOBA789)
left a comment
There was a problem hiding this comment.
意見が二転三転して申し訳ないんですが、現実的な利便性を考えると、既に gaia-ccsds-c2a に from_tlmcmddb 関数があるし、description 入れちゃっていいやという結論に至りました。
ParamField の名前以外はよさそうです
KOBA789 (KOBA789)
changed the title
Member
|
メジャーバージョンアップを伴うのでマージ・リリースタイミングを調整します |
KOBA789 (KOBA789)
approved these changes
Jun 12, 2024
shunsuke-shimomura
force-pushed
the
tco-tmiv-description
branch
from
9838700 to
c569a03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
変更の意図や背景
発端となる Issue
#246 で内容を提案した