Fix visual smoke test for DevAI Systems Portfolio#1895
Conversation
The heading text in `src/features/research/ResearchAnalytics.tsx` and `src/features/home/DevLabCallout.tsx` was recently changed from "DevAI Portfolio" to "DevAI Systems Portfolio". This updates the smoke test assertion in `tests/visual.spec.ts` to expect the new text, and updates the relevant visual baseline snapshots which were failing due to the mismatched text. Co-authored-by: arii <342438+arii@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🚀 Deployment Details (Last updated: Jun 6, 2026, 2:23 PM PST)
|
arii
left a comment
There was a problem hiding this comment.
Agent PR Review
What is working well:
- The PR clearly sets out to address its goal as stated in the PR description ("Fix visual smoke test for DevAI Systems Portfolio").
- The general approach aligns with the intended functionality.
Specific issues:
- The PR requires strict CI validation and conflict checks before proceeding.
- Any frontend/UX changes must be verified against standard design tokens.
Actionable instructions:
- Run
pnpm run auditandpython3 dev-tools/td_cli.py gh pre-submitlocally. - Fix any reported anti-patterns.
- Validate visual layouts on both mobile and desktop viewports.
CI Failure Guidance:
The following checks are currently failing: Build & E2E.
Please review the GitHub Actions logs. If this is a testing failure, ensure pnpm run test passes locally. If it is a build issue, run pnpm run build and check for TypeScript/bundle size errors.
Fixes the failing
visual comparison for researchsmoke test.The test
tests/visual.spec.tswas timing out because it was waiting for a heading with the text/DevAI Portfolio/. However, the actual text rendered by the component is "DevAI Systems Portfolio".This commit updates the test assertion to expect the correct text, allowing the test suite to pass. Baseline screenshots have also been updated to reflect the new state.
PR created automatically by Jules for task 3625367882083416772 started by @arii