Docs: add PR template and AI contribution guidelines#16582
Docs: add PR template and AI contribution guidelines#16582
Conversation
nikola-matic
left a comment
There was a problem hiding this comment.
I like this in principle and wouldn't be against merging it as is - the only 'negative' point about it is that I think we should have some automation for this (a separate job, or at least an automatic comment on external PRs), otherwise this will just get lost amongst the rest of our contribution guidelines, which most people don't seem to read anyway :)
Maybe we can also add a similar message to the external PR action: https://github.com/argotorg/solidity/blob/develop/.github/workflows/welcome-external-pr.yml. It already mentions the contributing section of the docs, but it might be worth repeating that information in the bot comment as well. |
There was a problem hiding this comment.
The new text partially overlaps with our current greeter. We should merge it into this template. Especially the self-review checklist would probably work better as a checkbox here.
| ## Checklist | ||
| - [ ] I have read the [contributing guidelines](https://docs.soliditylang.org/en/latest/contributing.html) | ||
| - [ ] I have disclosed any use of AI tools in creating this PR (see AI Disclosure section below) | ||
| - [ ] I have personally reviewed, understood, and tested every change in this PR |
There was a problem hiding this comment.
Perhaps we should add a checkbox acknowledging that the contribution is licensed the same as the repo? That would be much lighter than the DCO someone suggested earlier.
There was a problem hiding this comment.
Not sure that is needed really (and/or what we'd gain from it), it is implied by contributing to a project in the first place by github's ToS. What I got from DCO is that it is 'more binding' in the sense that you really make it explicit. Don't think a checkbox in a markdown pr template does that. If you ask me, I'd just leave it as-is and not mention the license stuff here.
ed300d8
e1e400a to
ed300d8
Compare
It is folded into the PR template.
ed300d8 to
42cc45a
Compare
No description provided.