Skip to content

Fix argv injection in _create_user and gpasswd loop #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Softer wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −6
Open

Fix argv injection in _create_user and gpasswd loop #4473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions archinstall/lib/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,16 +1922,17 @@ def _create_user(self, user: User) -> None:
if not handled_by_plugin:
info(f'Creating user {user.username}')

cmd = 'useradd -m'
cmd = ['arch-chroot', '-S', str(self.target), 'useradd', '-m']

if user.sudo:
cmd += ' -G wheel'
cmd += ['-G', 'wheel']

cmd += f' {user.username}'
cmd.append(user.username)

try:
self.arch_chroot(cmd)
except SysCallError as err:
run(cmd)
except CalledProcessError as err:
debug(f'Error creating user {user.username}: {err}')
raise SystemError(f'Could not create user inside installation: {err}')

for plugin in plugins.values():
Expand All @@ -1942,7 +1943,11 @@ def _create_user(self, user: User) -> None:
self.set_user_password(user)

for group in user.groups:
self.arch_chroot(f'gpasswd -a {user.username} {group}')
cmd = ['arch-chroot', '-S', str(self.target), 'gpasswd', '-a', user.username, group]
try:
run(cmd)
except CalledProcessError as err:
debug(f'Error adding {user.username} to group {group}: {err}')

if user.sudo:
self.enable_sudo(user)
Expand Down