Skip to content

Fix shell injection in Installer.user_set_shell and Installer.chown #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Apr 20, 2026
+10 −6
Merged

Fix shell injection in Installer.user_set_shell and Installer.chown #4443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions archinstall/lib/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1964,18 +1964,22 @@ def set_user_password(self, user: User) -> bool:
def user_set_shell(self, user: str, shell: str) -> bool:
info(f'Setting shell for {user} to {shell}')

cmd = ['arch-chroot', '-S', str(self.target), 'chsh', '-s', shell, user]
try:
self.arch_chroot(f'sh -c "chsh -s {shell} {user}"')
run(cmd)
return True
except SysCallError:
except CalledProcessError as err:
debug(f'Error setting user shell: {err}')
return False

def chown(self, owner: str, path: str, options: list[str] = []) -> bool:
cleaned_path = path.replace("'", "\\'")
def chown(self, owner: str, path: str, options: list[str] | None = None) -> bool:
options = options or []
cmd = ['arch-chroot', '-S', str(self.target), 'chown', *options, owner, path]
try:
self.arch_chroot(f"sh -c 'chown {' '.join(options)} {owner} {cleaned_path}'")
run(cmd)
return True
except SysCallError:
except CalledProcessError as err:
debug(f'Error changing ownership of {path}: {err}')
return False

def set_vconsole(self, locale_config: LocaleConfiguration) -> None:
Expand Down