Skip to content

Fix copying into target directory #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Apr 18, 2026
+5 −6
Merged

Fix copying into target directory #4441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions archinstall/lib/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,10 +505,9 @@ def sync_log_to_install_medium(self) -> bool:
# Copy over the install log (if there is one) to the install medium if
# at least the base has been strapped in, otherwise we won't have a filesystem/structure to copy to.
if self._helper_flags.get('base-strapped', False) is True:
absolute_logfile = logger.path
logfile_target = self.target / absolute_logfile
logfile_target.parent.mkdir(parents=True, exist_ok=True)
absolute_logfile.copy(logfile_target, preserve_metadata=True)
logfile_target = self.target / LPath(logger.directory).relative_to_root()
logfile_target.mkdir(parents=True, exist_ok=True)
logger.path.copy_into(logfile_target, preserve_metadata=True)

return True

Expand Down Expand Up @@ -1490,7 +1489,7 @@ def _add_limine_bootloader(
efi_dir_path.mkdir(parents=True, exist_ok=True)

for file in ('BOOTIA32.EFI', 'BOOTX64.EFI'):
(limine_path / file).copy(efi_dir_path)
(limine_path / file).copy_into(efi_dir_path)
except Exception as err:
raise DiskError(f'Failed to install Limine in {self.target}{efi_partition.mountpoint}: {err}')

Expand Down Expand Up @@ -1539,7 +1538,7 @@ def _add_limine_bootloader(

try:
# The `limine-bios.sys` file contains stage 3 code.
(limine_path / 'limine-bios.sys').copy(boot_limine_path)
(limine_path / 'limine-bios.sys').copy_into(boot_limine_path)

# `limine bios-install` deploys the stage 1 and 2 to the
self.arch_chroot(f'limine bios-install {parent_dev_path}', peek_output=True)
Expand Down