Skip to content

feat(APP-919): Make link text optional and use shared link wrapper#1208

Merged
evanaronson merged 3 commits into
mainfrom
feat/resources-optional-link-text
Jul 6, 2026
Merged

feat(APP-919): Make link text optional and use shared link wrapper#1208
evanaronson merged 3 commits into
mainfrom
feat/resources-optional-link-text

Conversation

@evanaronson

@evanaronson evanaronson commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Description

Make link text optional rather than forcing everyone to enter redundant link text. Was bad UX.

Because this adds some logic, added it to a wrapper around the Link component.

Type of Change

  • Major: Breaking change (change that would cause existing functionality to not work as expected)
  • Minor: Feature (non-breaking change which adds new functionality)
  • Patch: Enhancement (non-breaking change to an existing feature)
  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-mulcgclvf-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 79 passed, 1 skipped
HTML report View report
GitHub job ✅ completed

View run #4418

@evanaronson evanaronson changed the title Feat/resources optional link text feat(APP-919): make link text optional and use shared link wrapper Jul 4, 2026
@linear-code

linear-code Bot commented Jul 4, 2026

Copy link
Copy Markdown

APP-919

@evanaronson evanaronson marked this pull request as ready for review July 4, 2026 14:15
@evanaronson evanaronson requested a review from a team as a code owner July 4, 2026 14:15
@milosh86 milosh86 changed the title feat(APP-919): make link text optional and use shared link wrapper feat(APP-919): Make link text optional and use shared link wrapper Jul 6, 2026

@milosh86 milosh86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👏

@evanaronson evanaronson merged commit 4706e6a into main Jul 6, 2026
17 checks passed
@evanaronson evanaronson deleted the feat/resources-optional-link-text branch July 6, 2026 14:54
@arabot-1 arabot-1 mentioned this pull request Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants