Open
Conversation
d3acfe1 to
38839c5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
approved these changes
Apr 18, 2026
alinush
approved these changes
Apr 20, 2026
38839c5 to
8096dd4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ccf4491 to
154aec1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
jwk_consensus_config.moveis a new implementation of (the types & funcs of) JWK consensus-related configs originally implemented injwks.move.But soon we realized we will be fine with jwks.move and decided to not bother going through a governance proposal just for this. As a result, the feature reached devnet but never reached testnet+.
This change is to sunset the feature even in devnet for consistency across all networks.
How Has This Been Tested?
Existing tests.
Key Areas to Review
n/a
Type of Change
Which Components or Systems Does This Change Impact?
Checklist
Note
Medium Risk
Changes genesis initialization flow for JWK consensus by seeding on-chain
jwksresources (providers and patches) at genesis and removing the olderset_patches-during-keyless init path, which could affect devnet/testnet genesis outputs and JWK availability.Overview
Moves JWKS setup to be fully genesis-driven by adding
0x1::jwks::initialize_with_defaults(providers, patches)and invoking it fromvm-genesis, seedingSupportedOIDCProvidersandPatchesup front and immediately regeneratingPatchedJWKs.Genesis logic now derives the default OIDC provider list from
jwk_consensus_config_overrideand applies initial JWK patches (including a non-mainnet test key) during JWKS initialization, removing the priorjwk_consensus_configinitialization hook and the laterset_patchescall from keyless account setup. Rust types gainAsMoveValueforOIDCProviderto pass providers into Move.Reviewed by Cursor Bugbot for commit 154aec1. Bugbot is set up for automated code reviews on this repo. Configure here.