Skip to content

[compiler-v2] Implement a new abstraction for derived call graph query caching: fixes many subtle bugs. #19486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vineethk merged 2 commits into from
Apr 21, 2026
+233 −204
Merged

[compiler-v2] Implement a new abstraction for derived call graph query caching: fixes many subtle bugs. #19486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
428d7cb
Implement a new abstraction for derived call graph query caching: fix…
vineethk Apr 17, 2026
7e2d1e7
address bot comments
vineethk Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion third_party/move/move-compiler-v2/src/env_pipeline/inliner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ pub fn run_inlining(
}
}
}
env.filter_functions(|fun_id: &QualifiedFunId| !inline_funs.contains(fun_id));
env.retain_functions(|fun_id: &QualifiedFunId| !inline_funs.contains(fun_id));
}
}

Expand Down
14 changes: 0 additions & 14 deletions third_party/move/move-model/src/builder/module_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4838,14 +4838,7 @@ impl ModuleBuilder<'_, '_> {
spec: spec.into(),
def,
called_funs,
calling_funs: RefCell::default(),
transitive_closure_of_called_funs: RefCell::default(),
used_funs,
using_funs: RefCell::default(),
transitive_closure_of_used_funs: RefCell::default(),
used_functions_with_transitive_inline: RefCell::default(),
using_functions_with_transitive_inline: RefCell::default(),
used_structs: RefCell::default(),
};
function_data.insert(fun_id, data);
}
Expand Down Expand Up @@ -4885,14 +4878,7 @@ impl ModuleBuilder<'_, '_> {
spec: spec.into(),
def: None,
called_funs: Some(Default::default()),
calling_funs: RefCell::default(),
transitive_closure_of_called_funs: RefCell::default(),
used_funs: Some(Default::default()),
using_funs: RefCell::default(),
transitive_closure_of_used_funs: RefCell::default(),
used_functions_with_transitive_inline: RefCell::default(),
using_functions_with_transitive_inline: RefCell::default(),
used_structs: RefCell::default(),
};
function_data.insert(fun_id, data);
}
Expand Down
Loading
Loading