Skip to content

[Config] Update default testnet seeds. #19482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshLind merged 1 commit into from
Apr 17, 2026
+15 −28
Merged

[Config] Update default testnet seeds. #19482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions .github/actions/fullnode-sync/fullnode_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,6 @@
NUMBER_OF_HISTORICAL_TRANSACTIONS_TO_SYNC = 2000000 # The number of historical transactions to sync (when syncing from genesis)
SYNCING_DELTA_VERSIONS = 20000 # The number of versions to sync beyond the highest known at the job start

# Testnet seed peer constants
Copy link
Copy Markdown
Contributor

@sionescu sionescu Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the testnet PFN seed from here ?

Copy link
Copy Markdown
Contributor Author

@JoshLind JoshLind Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah, because we'll inject them by default on node startup, so no need to add them again here (manually in the node config) 😄

Copy link
Copy Markdown
Contributor

@sionescu sionescu Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshLind would it make sense to keep the seed map empty just in case we need to add seeds later ? Does the seed parameter override the built-in peers or is it additive ?

TESTNET_SEED_PEERS = {
"9D5AF3FFDFF04F7CD51AA9F902253067A40594C7831BF1265503220D585B4D20": {
"addresses": [
"/dns4/pfn0.euwe4-seed.fullnode.testnet.aptoslabs.com/tcp/6182/noise-ik/9D5AF3FFDFF04F7CD51AA9F902253067A40594C7831BF1265503220D585B4D20/handshake/0"
],
"role": "Upstream",
},
}

# Mainnet seed peer constants
MAINNET_SEED_PEERS = {
"A118B9BBBB8670D026C59C494317F7B6AA449A8E1B6AE0F9A6D434478AD1CC35": {
Expand Down Expand Up @@ -329,12 +319,9 @@ def setup_fullnode_config(network, bootstrapping_mode, continuous_syncing_mode,
# Enable storage sharding (AIP-97)
fullnode_config['storage']['rocksdb_configs'] = {"enable_storage_sharding": True}

# If we're syncing historical data, we need to add seed peers
if syncing_historical_data:
if network == MAINNET_STRING:
add_seed_peers(fullnode_config, MAINNET_SEED_PEERS)
elif network == TESTNET_STRING:
add_seed_peers(fullnode_config, TESTNET_SEED_PEERS)
# If we're syncing historical data on mainnet, we need to add seed peers
if syncing_historical_data and network == MAINNET_STRING:
Comment thread
JoshLind marked this conversation as resolved.
add_seed_peers(fullnode_config, MAINNET_SEED_PEERS)
Copy link
Copy Markdown
Contributor

@cursor cursor Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent seed peer handling between testnet and mainnet

Low Severity

The TESTNET_SEED_PEERS constant and its usage were fully removed from this CI script rather than updated, while MAINNET_SEED_PEERS is kept and still manually injected. This creates an asymmetry: mainnet historical syncing adds seeds via the Python script (preventing the config optimizer from applying its own), while testnet historical syncing now silently relies on the Rust config optimizer at node startup. Both paths work, but the mixed approach makes it unclear where seed management lives and could confuse future maintainers — as noted by a reviewer who asked "Why remove the testnet PFN seed from here?"

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2f3deaf. Configure here.


# Write the config file back to disk
with open(FULLNODE_CONFIG_NAME, "w") as file:
Expand Down
24 changes: 12 additions & 12 deletions config/src/config/config_optimizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,24 @@ const MAINNET_SEED_PEERS: [(&str, &str, &str); 1] = [(
// of (account address, public key, network address).
const TESTNET_SEED_PEERS: [(&str, &str, &str); 4] = [
(
"31e55012a7d439dcd16fee0509cd5855c1fbdc62057ba7fac3f7c88f5453dd8e",
"0x87bb19b02580b7e2a91a8e9342ec77ffd8f3ad967f54e77b22aaf558c5c11755",
"/dns/seed0.testnet.aptoslabs.com/tcp/6182/noise-ik/0x87bb19b02580b7e2a91a8e9342ec77ffd8f3ad967f54e77b22aaf558c5c11755/handshake/0",
"9d5af3ffdff04f7cd51aa9f902253067a40594c7831bf1265503220d585b4d20",
"0x9d5af3ffdff04f7cd51aa9f902253067a40594c7831bf1265503220d585b4d20",
"/dns/pfn0.euwe4-seed.fullnode.testnet.aptoslabs.com/tcp/6182/noise-ik/0x9d5af3ffdff04f7cd51aa9f902253067a40594c7831bf1265503220d585b4d20/handshake/0",
),
(
"116176e2af223a8b7f8db80dc52f7a423b4d7f8c0553a1747e92ef58849aff4f",
"0xc2f24389f31c9c18d2ceb69d153ad9299e0ea7bbd66f457e0a28ef41c77c2b64",
"/dns/seed1.testnet.aptoslabs.com/tcp/6182/noise-ik/0xc2f24389f31c9c18d2ceb69d153ad9299e0ea7bbd66f457e0a28ef41c77c2b64/handshake/0",
"64d807a57c289fb26aab73bfe1f192cdc0baa25c0ec72f707aefeff97300d434",
"0x64d807a57c289fb26aab73bfe1f192cdc0baa25c0ec72f707aefeff97300d434",
"/dns/pfn0.usce1.fullnode.testnet.aptoslabs.com/tcp/6182/noise-ik/0x64d807a57c289fb26aab73bfe1f192cdc0baa25c0ec72f707aefeff97300d434/handshake/0",
),
(
"12000330d7cd8a748f46c25e6ce5d236a27e13d0b510d4516ac84ecc5fddd002",
"0x171c661e5b785283978a74eafc52a906e68c73ae78119737b92f93507c753933",
"/dns/seed2.testnet.aptoslabs.com/tcp/6182/noise-ik/0x171c661e5b785283978a74eafc52a906e68c73ae78119737b92f93507c753933/handshake/0",
"0058220de6ba1af4c4a803e8727d9ed372104d2e60057cb16d6a99e646512826",
"0x0058220de6ba1af4c4a803e8727d9ed372104d2e60057cb16d6a99e646512826",
"/dns/pfn0.euwe4.fullnode.testnet.aptoslabs.com/tcp/6182/noise-ik/0x0058220de6ba1af4c4a803e8727d9ed372104d2e60057cb16d6a99e646512826/handshake/0",
),
(
"03c04549114877c55f45649aba48ac0a4ff086ab7bdce3b8cc8d3d9947bc0d99",
"0xafc38bf177bd825326a1c314748612137d2b35dae6472932806806a32c23174a",
"/dns/seed3.testnet.aptoslabs.com/tcp/6182/noise-ik/0xafc38bf177bd825326a1c314748612137d2b35dae6472932806806a32c23174a/handshake/0",
"18fe71c4253468e40c540e31e5127d1e341e20494bc0de8b4e4d434c14b54608",
"0x18fe71c4253468e40c540e31e5127d1e341e20494bc0de8b4e4d434c14b54608",
"/dns/pfn0.apne1.fullnode.testnet.aptoslabs.com/tcp/6182/noise-ik/0x18fe71c4253468e40c540e31e5127d1e341e20494bc0de8b4e4d434c14b54608/handshake/0",
),
];

Expand Down
Loading