[consensus] Lower opt_qs_minimum_batch_age_usecs from 50ms to 20ms#19480
Draft
danielxiangzl wants to merge 2 commits intodaniel/self-opt-metricsfrom
Draft
[consensus] Lower opt_qs_minimum_batch_age_usecs from 50ms to 20ms#19480danielxiangzl wants to merge 2 commits intodaniel/self-opt-metricsfrom
danielxiangzl wants to merge 2 commits intodaniel/self-opt-metricsfrom
Conversation
Experiment to increase opt batch inclusion rate, especially for EU-authored batches where proof forms in 15-30ms and the current 50ms threshold makes them almost always ineligible for opt path. Data from euwe6-1: - Batch age when pulled inline: p50=19ms, p90=39ms - Current opt pull starts at 50ms - many eligible batches are skipped - Intra-EU one-way network ~5ms; 20ms gives safe margin for dissemination Expected effects: - BATCH_SKIPPED_TOO_YOUNG rate drops - Per-author opt batch ratio increases (especially EU authors) - Opt proposal success rate should stay similar (monitor via Phase 1 metrics) Based on daniel/self-opt-metrics (PR #19479) which adds the observation metrics. Deploy on euwe6-1 only for Phase 2 canary. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… 10ms Phase 3 of the min_batch_age experiment, continuing from 20ms change in the previous commit. 10ms is the natural next step: - Intra-EU one-way network ~5ms; 10ms gives small margin for jitter - Captures ~90% of inline-pulled batches (euwe6-1 baseline: inline p10=10ms, p50=19ms, p90=39ms) - Expected to push EU-authored opt ratio further Deploy on euwe6-1 only, after observing 20ms for enough time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opt_qs_minimum_batch_age_usecsfrom 50ms → 20msTest plan
aptos_consensus_self_opt_proposal_committed / spawned— opt success rate (should stay ~95%+)quorum_store_self_proposed_batches_by_type_and_author{type=opt_batch}— should increasequorum_store_batch_skipped_too_young— should dropaptos_consensus_proposal_payload_availability_count{status=missing}on recipient validators — monitor for spikesRationale
From euwe6-1 data (1h window, 2026-04-16):
🤖 Generated with Claude Code