[mono-move] Fused jump and gas micro-ops#19471
Draft
calintat wants to merge 1 commit intocalin/gas-benchmarksfrom
Draft
[mono-move] Fused jump and gas micro-ops#19471calintat wants to merge 1 commit intocalin/gas-benchmarksfrom
calintat wants to merge 1 commit intocalin/gas-benchmarksfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prototype gas instrumentation via fused jump instructions. Instead of inserting
ChargeBlockops between basic blocks, gas costs are stored directly in jump instructions (gasfor unconditional jumps,gas_taken/gas_fallthroughfor conditional jumps) and charged at dispatch time. Entry-block gas is stored inFunction::entry_gasand charged inInterpreter::run. The instrumented program has the same instruction count as the original.How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist