feat: add ps restart command with --force flag#160
Open
blsmth wants to merge 2 commits into
Open
Conversation
Implements #39. Adds `apppack ps restart <process_type>` with two modes: - Graceful (default): calls ECS UpdateService with ForceNewDeployment=true to trigger a rolling restart without downtime. - Forced (--force): calls DescribeTasks to find running tasks matching the apppack:processType tag, then stops each via StopTask so ECS relaunches them immediately. The required IAM permissions (ecs:UpdateService, ecs:StopTask, ecs:ListTasks, ecs:DescribeTasks scoped by ecs:cluster) were already added to WebOperatorRole in apppack-backend commit 45261d2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apppack ps restart <process_type>CLI command (closes Add ps restart command #39)UpdateServicewithForceNewDeployment: truefor a zero-downtime rolling restart--force): stops all running containers matching theapppack:processTypetag viaStopTask; ECS relaunches them automaticallyps scale)Implementation
app/app.go: newRestartProcess(processType string, force bool) errormethod + unexportedgetTagFromTaskhelpercmd/ps.go: newpsRestartCmdregistered underpsCmd, with--forcebool flagNotes
The required IAM permissions (ecs:UpdateService, ecs:StopTask, ecs:ListTasks, ecs:DescribeTasks scoped by ecs:cluster) were already added to WebOperatorRole in apppack-backend commit 45261d2 - this is CLI-only work.
Closes #39