Skip to content

Handbook v2.5 fr - #190

Open
github-actions[bot] wants to merge 117 commits into
deploy-previewfrom
handbook_v2.5_fr
Open

Handbook v2.5 fr#190
github-actions[bot] wants to merge 117 commits into
deploy-previewfrom
handbook_v2.5_fr

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 25, 2024

Copy link
Copy Markdown

Automated pull request for fr handbook version v2.5

@oliviabboyd, please review changes and check the box when you finish

arranhamlet and others added 30 commits July 25, 2024 09:09
…dated. Should have a discussion on twitter links and non-English learning materials
ntluong95 and others added 29 commits October 29, 2024 22:25
raubreywhite added a commit that referenced this pull request Jul 24, 2026
Under the new workflows deploy-preview is built by nothing -- preview.yml
triggers on pull requests targeting main. So a translation PR opened against
deploy-preview got no build at all, while the same PR against main gets an
automatic preview deploy, which is what deploy-preview was approximating by
hand. Base changed to main.

The staleness guard compared the English branch head against origin/master.
master is being left behind deliberately, so that comparison would be against
a frozen commit and the check would never fire. Now origin/main, and the
variable is named latest_commit_base rather than latest_commit_master.

github.ref also moved out of the run: body into env:, matching the hardening
already applied to build-deploy.yml, so no workflow in this repo splices an
expression into shell source.

That last change initially added a SECOND env: block to a step that already
had one. YAML keeps the last duplicate key silently, so EN_BRANCH vanished and
GH_TOKEN survived -- the workflow would have run with an empty EN_BRANCH and
built nonsense branch names. check_workflow_vars.py caught it immediately,
which is the second real bug it has found since being added. EN_BRANCH is now
merged into the existing block.

NOT changed: the handbook_v*_en trigger and the seven hard-coded language
codes, which belong to the human translation process, and the seven open PRs
(#190-#196) still targeting deploy-preview -- retargeting other people-s pull
requests is not mine to do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants