Skip to content

Adding Watch Design #2

Open
PallaviIyer wants to merge 12 commits into
applibgroup:mainfrom
PallaviIyer:main
Open

Adding Watch Design #2
PallaviIyer wants to merge 12 commits into
applibgroup:mainfrom
PallaviIyer:main

Conversation

@PallaviIyer

Copy link
Copy Markdown

No description provided.

@CLAassistant

CLAassistant commented May 13, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

fetchDate: function () {
const date = new Date();
this.date_d = (String(date.getDate()))
this.date_m = (String(date.getMonth() + 1))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the code. Use this shortcut Ctrl+ shift + L

@archanaatr archanaatr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the comment

Comment thread LICENSE Outdated
2. Redistributions in binary form must reproduce the above copyright notice, this list
of conditions and the following disclaimer in the documentation and/or other materials
provided with the distribution.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Licence need to be updated.

Comment thread entry/src/main/js/MainAbility/app.js Outdated
@@ -0,0 +1,23 @@
import ability_featureAbility from '@ohos.ability.featureAbility'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add copyright details in all new js files

Comment thread entry/src/main/js/MainAbility/app.js Outdated
console.info('Permission Granted')
}).catch((error) => {
console.error('Permission Denied')
})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[12,3,6,9_point.png] - Change the icon name to better one and dont include commas in name

@@ -0,0 +1,8 @@
{
"strings": {
"hello": "Hello",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the unused strings

@archanaatr archanaatr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls chk the comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants