Conversation
Motivation: Android SDKs now exist and testing is good. Modifications: Add an Android GitHub Actions workflow using the latest nightly image and enable it in NIO targetting NIOCore (matching WASM testing). Result: More reusable workflows and more test coverage for NIO
This reverts commit 5d41e08.
glbrntt
approved these changes
Oct 22, 2025
Contributor
The Swift SDK for Android needs an extra post-install step before it can be used. I've submitted #3424 that should get this passing. |
rnro
pushed a commit
that referenced
this pull request
Oct 30, 2025
…re the SDK (#3424) Fixes the Android CI workflow ### Motivation: The recently-added Android SDK workflow [fails](https://github.com/apple/swift-nio/actions/runs/18718487605/job/53384086329?pr=3418) (as mentioned at #3418 (comment)). The confusing error message is due to a post-install step that is needed to download and link the Android NDK into the Swift SDK's artifactbundle. This PR also adds a one-line fix to [Sources/NIOPerformanceTester/main.swift](main...swift-android-sdk:swift-nio:main#diff-de179adbbfacb89c9533f4efd21f7f641eedc0c8642d7d650cdfc9d9278a7a55) that gets it building for Android so the entire swift-nio package can be built. ### Modifications: Adds a post-install step to the SDK installation that is needed for the Swift SDK for Android. This is the same technique used by swiftlang/github-workflows#172, and is described as a necessary step in the [Android getting started guide](https://github.com/swiftlang/swift-org-website/blob/0dc655ce267e7b6bada2a2032cc7855c3b5e19d9/documentation/articles/swift-android-getting-started.md) ### Result: The "Android Swift SDK" CI check should now pass successfully. See an example at https://github.com/swift-android-sdk/swift-nio/actions/runs/18761057590/job/53525442382 ### Note: This PR will _not_ pass the Android check until it has been merged, because it relies on being able to down the the script https://raw.githubusercontent.com/apple/swift-nio/main/scripts/install_swift_sdk.sh from `apple/swift-nio/main`, which will not include the Android fix until the PR is merged. But once it is merged, the Android SDK CI should start passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Android SDKs now exist and testing is good.
Modifications:
Add an Android GitHub Actions workflow using the latest nightly image
and enable it in NIO targetting NIOCore (matching WASM testing).
Result:
More reusable workflows and more test coverage for NIO
See this in action here (the CI job works but NIOCore fails to build): https://github.com/apple/swift-nio/actions/runs/18718487605/job/53384086329?pr=3418