Enable codeql scanning #1532
+140
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| amends "@gha/Workflow.pkl" | ||
|
|
||
| import "@gha/catalog.pkl" | ||
|
|
||
| on { | ||
| push { | ||
| branches { | ||
| "main" | ||
| } | ||
| } | ||
| pull_request {} | ||
| schedule { | ||
| // Run at 01:38 on Saturday | ||
| new { cron = "38 1 * * 6" } | ||
| } | ||
| } | ||
|
|
||
| local class CodeQLScan { | ||
| language: String | ||
|
|
||
| `build-mode`: String | ||
| } | ||
|
|
||
| local scans: Listing<CodeQLScan> = new { | ||
| new { | ||
| language = "actions" | ||
| `build-mode` = "none" | ||
| } | ||
| new { | ||
| language = "java-kotlin" | ||
| `build-mode` = "autobuild" | ||
| } | ||
| new { | ||
| language = "javascript-typescript" | ||
| `build-mode` = "none" | ||
| } | ||
| } | ||
|
|
||
| jobs { | ||
| for (scan in scans) { | ||
| ["analyze-\(scan.language)"] { | ||
|
Contributor
There was a problem hiding this comment. Isn't it better/easier to go with a matrix build instead of multiple jobs? 🤔 🤷♂️
Member
Author
There was a problem hiding this comment. Matrices feel like a poor man's for loop that we can express much more easily with Pkl. And, you get actual Pkl dot access this way, rather than a stringy typed value ( |
||
| name = "Analyze (\(scan.language))" | ||
| `runs-on` = "ubuntu-latest" | ||
| permissions { | ||
| `security-events` = "write" | ||
| } | ||
| steps { | ||
| catalog.`actions/checkout@v6` | ||
| new { | ||
| name = "Initialize CodeQL" | ||
| uses = "github/codeql-action/init@v4" | ||
| with { | ||
| ["languages"] = scan.language | ||
| ["build-mode"] = scan.`build-mode` | ||
| } | ||
| } | ||
| new { | ||
| name = "Perform CodeQL Analysis" | ||
| uses = "github/codeql-action/analyze@v4" | ||
| with { | ||
| ["category"] = "/language:\(scan.language)" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to run this on push or PR? Having this able to block PRs would be very handy. I'd be interested in adding at least one custom query to block a problem pattern in CliCommand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was concerned about how long these things take to run. But, we can play around with it and see what happens!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis for java-kotlin finished within a minute of the gradle-check job, so I think this would probably be okay to enable on PRs. A <1m delay in exchange for better security enforcement on PRs seems okay to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added PRs