Remove Config.makeConfig#1531
Merged
bioball merged 3 commits intoapple:mainfrom Apr 17, 2026
Merged
Conversation
bioball
force-pushed
the
remove-makeConfig
branch
from
3e06457 to
f8bba84
Compare
odenix
reviewed
Apr 17, 2026
| import org.pkl.config.java.mapper.ValueMapper; | ||
| import org.pkl.core.Composite; | ||
|
|
||
| class Utils { |
Contributor
There was a problem hiding this comment.
Could be ConfigUtils to make it a bit more unique and easier to search for / open.
This doesn't really make sense as part of the `Config` API. We can maybe make class `Utils` public, but, I don't know how useful it is anyways.
bioball
force-pushed
the
remove-makeConfig
branch
from
89b8747 to
4a6d5a3
Compare
HT154
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't really make sense as part of the
ConfigAPI.We can maybe make class
Utilspublic, but, I don't know how useful it is anyways; it's more of an implementation detail.