Skip to content

fix: prefer chromedriverPorts pool over single chromedriverPort when both are set #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AsijitM wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

fix: prefer chromedriverPorts pool over single chromedriverPort when both are set #1076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/commands/context/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,17 @@ export async function setupNewChromedriver(
opts.chromedriverPort = (opts as any).chromeDriverPort;
}

if (opts.chromedriverPort) {
if (opts.chromedriverPort && opts.chromedriverPorts) {
// If both the single 'chromedriverPort' and the 'chromedriverPorts' pool are provided, prefer
// the pool. Otherwise the explicitly configured range would be silently bypassed by the single
// port, which is surprising and makes it impossible to guarantee a per-session port is picked
// from the pool (e.g. when several parallel sessions share the same host).
this.log.info(
`Both 'chromedriverPort' (${opts.chromedriverPort}) and 'chromedriverPorts' were provided; ` +
`preferring a free port from the 'chromedriverPorts' pool and ignoring 'chromedriverPort'`,
);
opts.chromedriverPort = await getChromedriverPort.bind(this)(opts.chromedriverPorts);
} else if (opts.chromedriverPort) {
this.log.debug(`Using user-specified port ${opts.chromedriverPort} for chromedriver`);
} else {
// if a single port wasn't given, we'll look for a free one
Expand Down
Loading