Repository navigation
[Relax][TVMScript] Keep metadata for bare constant If-branch bodies - #20946
Open
cchung100m wants to merge 2 commits into
Open
cchung100m wants to merge 2 commits into
cchung100m wants to merge 2 commits into
Conversation
cchung100m
marked this pull request as ready for review
November 9, 2026 13:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Committers,
This PR fixes issue #20892. Any suggestions would be greatly appreciated.
Root Cause
RelaxSeqBody(src/relax/script/printer/region.cc) calledDocTranslatorObj::Translate(SeqExpr).SeqExprDocTranslatereturns the body Doc unchanged, andTranslateunconditionally callsRecordOrigin(result, value)on the returned Doc(doc_translator.h). This overwrites theGenericConstorigin set byAddMetadatawith theSeqExpr.CollectMetadata(printer.cc) only accepts a reference whose recorded origin has the same type key as the registry key (ir.GenericConst), so it skipped the reference andRenderScriptomitted the declaration.FunctionDocTranslatetranslatesfunc->body->bodydirectly and does not hit this, which matches the observation that a bare constant function body with noIfround-trips correctly.Solution
Move the
SeqExprbody translation (blocks, implicit-def handling, body) intoTranslateSeqExprContentsand call it from bothSeqExprDocTranslateandRelaxSeqBody, soRelaxSeqBodyno longer goes throughTranslate(SeqExpr)and the body Doc keeps its own origin.