Skip to content

Cleanup Adobe Flex SDK installation following AS3 library removal#3404

Merged
kpumuk merged 1 commit intoapache:masterfrom
kpumuk:as3-cleanup
Apr 18, 2026
Merged

Cleanup Adobe Flex SDK installation following AS3 library removal#3404
kpumuk merged 1 commit intoapache:masterfrom
kpumuk:as3-cleanup

Conversation

@kpumuk
Copy link
Copy Markdown
Member

@kpumuk kpumuk commented Apr 16, 2026

AS3 support was dropped in #2329, but we still install Adobe Flex SDK in a few places. For example, it takes 654.4 MiB in 2 layers in MSVC docker (325.0 MiB downloaded archive + 329.4 MiB uncompressed).

I am investigating the insane MSVC build times, a Docker image download step dominates the build with 27 minutes clock time.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@mergeable mergeable Bot added the build and general CI cmake, automake and build system changes label Apr 16, 2026
@kpumuk
Copy link
Copy Markdown
Member Author

kpumuk commented Apr 16, 2026

I will be honest, have zero clue how the image gets built :-) I see it can't be found and the hash changed https://github.com/kpumuk/thrift/actions/runs/24540103116/job/71743853687

@Jens-G any thoughts?

@kpumuk
Copy link
Copy Markdown
Member Author

kpumuk commented Apr 17, 2026 •
edited
Loading

Looks like it might be caused by the fact I run it from my fork, which does not have ghcr and so the error is "manifest unknown"...

Edit: progresses now https://github.com/apache/thrift/actions/runs/24540715347/job/71745689621?pr=3404

I am also kind of curious about the difference between MSVC and Appveyor builds...

@mergeable mergeable Bot added the github_actions Pull requests that update GitHub Actions code label Apr 17, 2026
kpumuk
kpumuk commented Apr 17, 2026
View reviewed changes
Comment thread build/docker/msvc/Dockerfile

# Install OpenSSL 3.6.1
ADD --checksum=sha256:8ce11c409adbd177ca627115bc697c3b66c414bb36175ebb375341eb426894a8 https://slproweb.com/download/Win64OpenSSL-3_6_1.exe C:\TEMP\openssl.exe
ADD --checksum=sha256:c395482a1af33b2cdd4b801b227c864ed049e0f6aff79413d31b4fa916a67b1a https://slproweb.com/download/Win64OpenSSL-3_6_2.exe C:\TEMP\openssl.exe
Copy link
Copy Markdown
Member Author

@kpumuk kpumuk Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

ADD failed: failed to GET https://slproweb.com/download/Win64OpenSSL-3_6_1.exe with status 404 Not Found: <html>
<head><title>404 Not Found</title></head>
<body>
<center><h1>404 Not Found</h1></center>
<hr><center>nginx/1.26.0</center>
</body>
</html>

slproweb/opensslhashes@8c3f395

@kpumuk kpumuk marked this pull request as ready for review April 17, 2026 02:21
@Jens-G
Copy link
Copy Markdown
Member

Jens-G commented Apr 17, 2026 •
edited
Loading

Good catch. I might have overlooked that. We also dropped Haskell some time ago. So if you happen find sth pointing in that direction, most likely that can be removed as well.

I will be honest, have zero clue how the image gets built :-) I see it can't be found and the hash changed https://github.com/kpumuk/thrift/actions/runs/24540103116/job/71743853687

@Jens-G any thoughts?

https://github.com/kpumuk/thrift/actions/runs/24540103116/workflow thats the workflow file used for that run. These yaml files live under .github in the source tree. Does that answer the question?

@kpumuk
Copy link
Copy Markdown
Member Author

kpumuk commented Apr 17, 2026

https://github.com/kpumuk/thrift/actions/runs/24540103116/workflow thats the workflow file used for that run. These yaml files live under .github in the source tree. Does that answer the question?

Yeah. I figured it was breaking because the error was different from what the script expected :-) Thanks!

@kpumuk kpumuk merged commit 6c61fea into apache:master Apr 18, 2026
86 checks passed
@kpumuk kpumuk deleted the as3-cleanup branch April 18, 2026 12:26
@kpumuk
Copy link
Copy Markdown
Member Author

kpumuk commented Apr 18, 2026 •
edited
Loading

msvc-d5d97583f97d (new) is 9,511,267,796 bytes total compressed registry size (8.858 GiB, 37 layers). msvc-cfc34fb57460 (old) is 10,224,959,428 bytes (9.523 GiB, 39 layers). Net: d5... is smaller by 713,691,632 bytes (680.6 MiB). The main size win is removal of Adobe Flex from the older Dockerfile; that saves 654.4 MiB by itself, partially offset by a larger refreshed parent image layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jens-G Jens-G Jens-G approved these changes

@fishy fishy Awaiting requested review from fishy fishy is a code owner

@jimexist jimexist Awaiting requested review from jimexist jimexist is a code owner

Assignees

No one assigned

Labels

build and general CI cmake, automake and build system changes github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kpumuk @Jens-G