Skip to content

Replace addr with factory in TServerSocket#3379

Merged
fishy merged 1 commit intoapache:masterfrom
qr243vbi:patch-1
Apr 23, 2026
Merged

Replace addr with factory in TServerSocket#3379
fishy merged 1 commit intoapache:masterfrom
qr243vbi:patch-1

Conversation

@qr243vbi
Copy link
Copy Markdown
Contributor

@qr243vbi qr243vbi commented Apr 7, 2026 •
edited
Loading

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@qr243vbi
Copy link
Copy Markdown
Contributor Author

qr243vbi commented Apr 7, 2026

This allows to use named pipes from go-winio.

@mergeable mergeable Bot added the golang patches related to go language label Apr 7, 2026
@Jens-G Jens-G requested a review from fishy April 8, 2026 23:13
fishy
fishy reviewed Apr 9, 2026
View reviewed changes
Comment thread lib/go/thrift/server_socket.go Outdated
@qr243vbi qr243vbi force-pushed the patch-1 branch 4 times, most recently from d57b3cc to 01ef926 Compare April 9, 2026 05:32
@qr243vbi qr243vbi requested a review from fishy April 9, 2026 05:34
@qr243vbi qr243vbi force-pushed the patch-1 branch 2 times, most recently from 61aaeaa to 160aec1 Compare April 9, 2026 05:39
fishy
fishy reviewed Apr 9, 2026
View reviewed changes
Comment thread lib/go/thrift/server_socket.go Outdated
Comment thread lib/go/thrift/server_socket.go Outdated
Comment thread lib/go/thrift/server_socket.go
fishy
fishy reviewed Apr 9, 2026
View reviewed changes
Comment thread lib/go/thrift/server_socket.go Outdated
fishy
fishy reviewed Apr 9, 2026
View reviewed changes
Comment thread lib/go/thrift/server_socket.go Outdated
Comment thread lib/go/thrift/server_socket.go Outdated
@qr243vbi qr243vbi requested a review from fishy April 9, 2026 22:47
fishy
fishy reviewed Apr 9, 2026
View reviewed changes
Comment thread lib/go/thrift/server_socket.go
Comment thread lib/go/thrift/server_socket.go Outdated
Comment thread lib/go/thrift/server_socket.go Outdated
@qr243vbi qr243vbi requested a review from fishy April 10, 2026 02:27
fishy
fishy reviewed Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@fishy fishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think "factory" is the best term here, maybe "listener" or something like that?

Also please squash your commits.

Comment thread lib/go/thrift/server_socket.go Outdated
@qr243vbi
Copy link
Copy Markdown
Contributor Author

qr243vbi commented Apr 15, 2026

I still don't think "factory" is the best term here, maybe "listener" or something like that?

Also please squash your commits.

Right

@mergeable mergeable Bot added c_glib c++ dart Pull requests that update Dart code delphi erlang labels Apr 15, 2026
@qr243vbi qr243vbi closed this Apr 15, 2026
@mergeable mergeable Bot added haxe java Pull requests that update Java code javascript Pull requests that update Javascript code labels Apr 15, 2026
@qr243vbi qr243vbi reopened this Apr 15, 2026
@qr243vbi qr243vbi requested a review from fishy April 15, 2026 09:57
@kpumuk kpumuk removed javascript Pull requests that update Javascript code java Pull requests that update Java code c++ erlang delphi dart Pull requests that update Dart code haxe c_glib labels Apr 15, 2026
@fishy
Copy link
Copy Markdown
Member

fishy commented Apr 15, 2026

the code doesn't compile: https://github.com/apache/thrift/actions/runs/24448228720/job/71489703825?pr=3379

@qr243vbi qr243vbi closed this Apr 21, 2026
@qr243vbi qr243vbi reopened this Apr 21, 2026
@qr243vbi
Copy link
Copy Markdown
Contributor Author

qr243vbi commented Apr 21, 2026

the code doesn't compile: https://github.com/apache/thrift/actions/runs/24448228720/job/71489703825?pr=3379

fixed

@fishy
Copy link
Copy Markdown
Member

fishy commented Apr 21, 2026

the code doesn't compile: https://github.com/apache/thrift/actions/runs/24448228720/job/71489703825?pr=3379

fixed

still doesn't work: https://github.com/apache/thrift/actions/runs/24713839666/job/72357334569?pr=3379

please test it locally before asking for review.

@qr243vbi qr243vbi closed this Apr 23, 2026
@qr243vbi qr243vbi reopened this Apr 23, 2026
@qr243vbi
Copy link
Copy Markdown
Contributor Author

qr243vbi commented Apr 23, 2026

the code doesn't compile: https://github.com/apache/thrift/actions/runs/24448228720/job/71489703825?pr=3379

fixed

still doesn't work: https://github.com/apache/thrift/actions/runs/24713839666/job/72357334569?pr=3379

please test it locally before asking for review.

Fixed again

@fishy fishy merged commit ff01b9e into apache:master Apr 23, 2026
169 of 171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fishy fishy fishy approved these changes

@Jens-G Jens-G Awaiting requested review from Jens-G

@jimexist jimexist Awaiting requested review from jimexist

@mhlakhani mhlakhani Awaiting requested review from mhlakhani

@emmenlau emmenlau Awaiting requested review from emmenlau

Assignees

No one assigned

Labels

golang patches related to go language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qr243vbi @fishy @kpumuk