-
Notifications
You must be signed in to change notification settings - Fork 482
GH-563: Make ColumnMetaData.path_in_schema optional
#564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -885,8 +885,17 @@ struct ColumnMetaData { | |
| * whether we can decode those pages. **/ | ||
| 2: required list<Encoding> encodings | ||
|
|
||
| /** Path in schema **/ | ||
| 3: required list<string> path_in_schema | ||
| /** | ||
| * Path in schema | ||
| * | ||
| * The writing of this field has been made optional as of version 2.X.0. | ||
| * The information contained in this field is easily obtainable from | ||
| * the schema, and redundantly storing it here can lead to unnecessary | ||
| * bloat in the footer. Writers are encouraged to make the writing of | ||
| * this field optional, but for maximal compatibility should default to | ||
| * writing the field until at least Month 202X. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Based on "Forward incompatible features/changes should not be turned on by default until 2 years after the parquet-java implementation containing the feature is released." Lets maybe fill in the date as September 2028, assuming we get things merged by a september java release?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've gone ahead and put Sept 2028 in the text for now. We can update as needed later. |
||
| */ | ||
| 3: optional list<string> path_in_schema | ||
|
|
||
| /** Compression codec **/ | ||
| 4: required CompressionCodec codec | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.