apps/cmake: Make hello_rust_cargo buildable with cmake by toku-mac · Pull Request #3479 · apache/nuttx-apps

toku-mac · 2026-05-13T06:34:45Z

Summary

Fixes errors related to cargo options and library paths when building hello_rust_cargo with CMake.
Related NuttX Apps Issue #3472 , Issue #3473

Impact

Impact on build: enables building with cargo and cmake.

Testing

I confirm that changes are verified on local setup and works as intended:

Build Host(s): OS (Linux), CPU(Intel), compiler(cc 15.2.0)
Target(s): arch(sim)
Ensure your PATH environment variable is properly configured to allow execution of: menuconfig, olddefconfig, savedefconfig, and setconfig.
Use the Rust toolchain version prior to nightly-2026-04-29 to avoid errors related to lib/rustlib/src/rust/library/std/src/sys/net/connection/socket/unix.rs.

Configuration:

~/nuttxspace/nuttx$ make distclean
NuttX has not been configured!
To configure the project:
  tools/configure.sh <config>
For a list of available configurations:
  tools/configure.sh -L
~/nuttxspace/nuttx$ cmake -S . -B build-debug -DBOARD_CONFIG=sim:nsh -GNinja
-- nuttx_add_subdirectory: Skipping cxx-oot-build
-- Initializing NuttX
Loaded configuration '/home/toku/nuttxspace/nuttx/build-debug/.config.compressed'
Minimal configuration saved to '/home/toku/nuttxspace/nuttx/build-debug/defconfig.tmp'
  Select HOST_LINUX=y
  Select HOST_X86_64=y
--   CMake:  4.2.3
--   Ninja:  1.13.2
--   Board:  sim
--   Config: nsh
--   Appdir: /home/toku/nuttxspace/apps
-- The C compiler identification is GNU 15.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- NuttX Host Tools
-- CMake C compiler: GNU
-- CMake system name: Linux
-- CMake host system processor: x86_64
   TOOLS_DIR path is "/home/toku/nuttxspace/nuttx"
   HOST = Linux
-- Configuring done (1.3s)
-- Generating done (0.0s)
-- Build files have been written to: /home/toku/nuttxspace/nuttx/build-debug/bin_host
-- The C compiler identification is GNU 15.2.0
-- The CXX compiler identification is GNU 15.2.0
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/cc
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- nuttx_add_subdirectory: Skipping cxx-oot-build
-- Configuring done (7.8s)
-- Generating done (0.5s)
-- Build files have been written to: /home/toku/nuttxspace/nuttx/build-debug
~/nuttxspace/nuttx$ printf "CONFIG_SYSTEM_TIME64=y
CONFIG_FS_LARGEFILE=y
CONFIG_TLS_NELEM=16
CONFIG_DEV_URANDOM=y
CONFIG_EXAMPLES_HELLO_RUST_CARGO=y
CONFIG_EXAMPLES_HELLO_RUST_CARGO_STACKSIZE=8192
" >> build-debug/.config
~/nuttxspace/nuttx$ cmake --build build-debug -t olddefconfig
[0/1] Re-running CMake...
-- NuttX Host Tools
-- CMake C compiler: GNU
-- CMake system name: Linux
-- CMake host system processor: x86_64
   TOOLS_DIR path is "/home/toku/nuttxspace/nuttx"
   HOST = Linux
-- Configuring done (0.0s)
-- Generating done (0.0s)
-- Build files have been written to: /home/toku/nuttxspace/nuttx/build-debug/bin_host
-- nuttx_add_subdirectory: Skipping cxx-oot-build
-- Configuring done (0.4s)
-- Generating done (0.3s)
-- Build files have been written to: /home/toku/nuttxspace/nuttx/build-debug
[1/2] cd /home/toku/nuttxspace/nuttx && /usr/bin/cmake -E ...n/cmake -E touch /home/toku/nuttxspace/nuttx/CMakeLists.tx
/home/toku/nuttxspace/nuttx/build-debug/.config:1814: warning: SYSTEM_TIME64 (defined at sched/Kconfig:170) set more than once. Old value "n", new value "y".
/home/toku/nuttxspace/nuttx/build-debug/.config:1815: warning: FS_LARGEFILE (defined at fs/Kconfig:20) set more than once. Old value "n", new value "y".
/home/toku/nuttxspace/nuttx/build-debug/.config:1816: warning: TLS_NELEM (defined at libs/libc/tls/Kconfig:45) set more than once. Old value "0", new value "16".
/home/toku/nuttxspace/nuttx/build-debug/.config:1817: warning: DEV_URANDOM (defined at drivers/crypto/Kconfig:16) set more than once. Old value "n", new value "y".
/home/toku/nuttxspace/nuttx/build-debug/.config:1818: warning: EXAMPLES_HELLO_RUST_CARGO (defined at /home/toku/nuttxspace/apps/examples/rust/hello/Kconfig:6) set more than once. Old value "n", new value "y".
Loaded configuration '/home/toku/nuttxspace/nuttx/build-debug/.config'
Configuration saved to '/home/toku/nuttxspace/nuttx/build-debug/.config'

Testing logs before change:

~/nuttxspace/nuttx$ cmake --build build-debug -j 6
[0/1] Re-running CMake...
-- NuttX Host Tools
-- CMake C compiler: GNU
-- CMake system name: Linux
-- CMake host system processor: x86_64
   TOOLS_DIR path is "/home/toku/nuttxspace/nuttx"
   HOST = Linux
-- Configuring done (0.0s)
-- Generating done (0.0s)
-- Build files have been written to: /home/toku/nuttxspace/nuttx/build-debug/bin_host
-- nuttx_add_subdirectory: Skipping cxx-oot-build
-- Configuring done (1.2s)
-- Generating done (1.0s)
-- Build files have been written to: /home/toku/nuttxspace/nuttx/build-debug
[1214/1230] Building Rust crate hello
FAILED: [code=1] apps/examples/rust/hello/hello/target/x86_64-unknown-nuttx/debug/libhello.a /home/toku/nuttxspace/nuttx/build-debug/apps/examples/rust/hello/hello/target/x86_64-unknown-nuttx/debug/libhello.a
cd /home/toku/nuttxspace/nuttx/build-debug/apps/examples/rust/hello && /usr/bin/cmake -E env NUTTX_INCLUDE_DIR=/home/toku/nuttxspace/nuttx/include:/home/toku/nuttxspace/nuttx/build-debug/include:/home/toku/nuttxspace/nuttx/build-debug/include/arch RUSTFLAGS= cargo build --debug -Zbuild-std=std,panic_abort --manifest-path /home/toku/nuttxspace/apps/examples/rust/hello/Cargo.toml --target /tools/x86_64-unknown-nuttx.json --target-dir /home/toku/nuttxspace/nuttx/build-debug/apps/examples/rust/hello/hello/target/x86_64-unknown-nuttx
error: unexpected argument '--debug' found

  tip: `--debug` is the default for `cargo build`; instead `--release` is supported

Usage: cargo build [OPTIONS]

For more information, try '--help'.
[1215/1230] Linking C static library libs/libc/libc.a
ninja: build stopped: subcommand failed.

Testing logs after change:

~/nuttxspace/nuttx$ cmake --build build-debug -j 6
[0/1] Re-running CMake...
-- NuttX Host Tools
-- CMake C compiler: GNU
-- CMake system name: Linux
-- CMake host system processor: x86_64
   TOOLS_DIR path is "/home/toku/nuttxspace/nuttx"
   HOST = Linux
-- Configuring done (0.0s)
-- Generating done (0.0s)
-- Build files have been written to: /home/toku/nuttxspace/nuttx/build-debug/bin_host
-- nuttx_add_subdirectory: Skipping cxx-oot-build
-- Configuring done (0.3s)
-- Generating done (0.3s)
-- Build files have been written to: /home/toku/nuttxspace/nuttx/build-debug
[1216/1230] Building Rust crate hello
   Compiling compiler_builtins v0.1.160 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/compiler-builtins/compiler-builtins)
   Compiling core v0.0.0 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core)
   Compiling libc v0.2.185
   Compiling object v0.37.3
   Compiling std v0.0.0 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std)
   Compiling proc-macro2 v1.0.106
   Compiling unicode-ident v1.0.24
   Compiling quote v1.0.45
   Compiling serde_core v1.0.228
   Compiling zmij v1.0.21
   Compiling serde v1.0.228
   Compiling serde_json v1.0.149
   Compiling syn v2.0.117
   Compiling serde_derive v1.0.228
   Compiling rustc-std-workspace-core v1.99.0 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-core)
   Compiling alloc v0.0.0 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc)
   Compiling memchr v2.7.6
   Compiling adler2 v2.0.1
   Compiling panic_abort v0.0.0 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/panic_abort)
   Compiling cfg-if v1.0.4
   Compiling rustc-demangle v0.1.27
   Compiling rustc-literal-escaper v0.0.7
   Compiling unwind v0.0.0 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/unwind)
   Compiling rustc-std-workspace-alloc v1.99.0 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-alloc)
   Compiling panic_unwind v0.0.0 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/panic_unwind)
   Compiling gimli v0.32.3
   Compiling std_detect v0.1.5 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std_detect)
   Compiling miniz_oxide v0.8.9
   Compiling hashbrown v0.17.0
   Compiling addr2line v0.25.1
   Compiling proc_macro v0.0.0 (/home/toku/.rustup/toolchains/nightly-2026-04-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/proc_macro)
   Compiling pin-project-lite v0.2.17
   Compiling memchr v2.8.0
   Compiling itoa v1.0.18
   Compiling tokio v1.52.3
   Compiling hello v0.1.0 (/home/toku/nuttxspace/apps/examples/rust/hello)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.90s
[1229/1230] Pac SIM with dynamic libs in nuttx.tgz
'/usr/lib/x86_64-linux-gnu/libz.so.1' -> 'sim-pac/libs/libz.so.1'
'/usr/lib/x86_64-linux-gnu/libgcc_s.so.1' -> 'sim-pac/libs/libgcc_s.so.1'
'/usr/lib/x86_64-linux-gnu/libc.so.6' -> 'sim-pac/libs/libc.so.6'
'/lib64/ld-linux-x86-64.so.2' -> 'sim-pac/ld-linux-x86-64.so.2'
~/nuttxspace/nuttx$ ./build-debug/nuttx

NuttShell (NSH) NuttX-12.13.0
nsh> help
help usage:  help [-v] [<cmd>]

    .           cmp         fdinfo      mkrd        rm          true
    [           dirname     free        mount       rmdir       truncate
    ?           df          help        mv          set         uname
    alias       dmesg       hexdump     pidof       kill        umount
    unalias     echo        losetup     poweroff    pkill       unset
    basename    env         ln          quit        sleep       uptime
    break       exec        ls          printf      usleep      watch
    cat         exit        mkdir       ps          source      xd
    cd          expr        mkfatfs     pwd         test        wait
    cp          false       mkfifo      readlink    time

Builtin Apps:
    dd                  nsh                 gpio
    dumpstack           sh                  hello
    gcov                ostest              hello_rust_cargo
nsh> uname -a
NuttX 12.13.0 d9f6216f30-dirty May 13 2026 13:06:16 sim sim
nsh> hello_rust_cargo
{"name":"John","age":30}
{"name":"Jane","age":25}
Deserialized: Alice is 28 years old
Pretty JSON:
{
  "name": "Alice",
  "age": 28
}
Hello world from tokio!

# An infinite loop here.

PR verification Self-Check

My PR adheres to Contributing Guidelines and Documentation (git commit title and message, coding standard, etc).
My PR is ready for review and can be safely merged into a codebase.

* Resolve APPDIR. * Remove "debug" from RUST_PROFILE_FLAG. * Add JSON specification compatibility to RUST_PROFILE_FLAG. * Correct the directory structure for RUST_LIB_PATH. Signed-off-by: Shoji Tokunaga <toku@mac.com>

lupyuen · 2026-05-13T07:32:07Z

@no1wudi Could you help to review this PR? Thanks :-)

lupyuen · 2026-05-13T07:47:07Z

@toku-mac The CI Check failed with this error: https://github.com/apache/nuttx-apps/actions/runs/25782691618/job/75736117186?pr=3479#step:4:84

/home/runner/work/nuttx-apps/nuttx-apps/apps/cmake/nuttx_add_rust.cmake: error: execute permissions detected!
ERROR __main__.py:618: Check failed: /home/runner/work/nuttx-apps/nuttx-apps/apps/cmake/nuttx_add_rust.cmake
cmake-format check failed, run following command to update the style:
  $ cmake-format <src> -o <dst>

Could you remove the Execute Permission from nuttx_add_rust.cmake? Thanks :-)

➜  cmake git:(fix_cargo_cmake) $ ls -l
total 40
-rw-r--r--  1 luppy  wheel  2377 13 May 15:41 nuttx_add_luamod.cmake
-rwxr-xr-x  1 luppy  wheel  6397 13 May 15:41 nuttx_add_rust.cmake
-rw-r--r--  1 luppy  wheel  2501 13 May 15:41 nuttx_add_wamrmod.cmake
-rw-r--r--  1 luppy  wheel  2091 13 May 15:41 nuttx_wasm_interface.cmake

toku-mac · 2026-05-13T07:59:51Z

Sorry, can you check commit 89b0558?

* Correct the permissions of `nuttx_add_rust.cmake` to 644. Signed-off-by: Shoji Tokunaga <toku@mac.com>

lupyuen · 2026-05-13T08:48:25Z

@toku-mac Sorry there's a CMake formatting problem: https://github.com/apache/nuttx-apps/actions/runs/25786185066/job/75745216835?pr=3479#step:4:85

❌ Missing Signed-off-by
ERROR __main__.py:618: Check failed: /home/runner/work/nuttx-apps/nuttx-apps/apps/cmake/nuttx_add_rust.cmake
cmake-format check failed, run following command to update the style:
  $ cmake-format <src> -o <dst>

Could you run this then commit the the updated CMakefile, remember to add "Signed-off-by" to the commit:

cd cmake
python3 -m venv .
source ./bin/activate
python3 -m pip install cmake-format
cmake-format nuttx_add_rust.cmake -o nuttx_add_rust.cmake

Here are the changes:

$ git diff
 function(nuttx_rust_target_triple ARCHTYPE ABITYPE CPUTYPE OUTPUT)
-  get_filename_component(APPDIR "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/.." ABSOLUTE)
+  get_filename_component(APPDIR "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/.."
+                         ABSOLUTE)
   if(ARCHTYPE STREQUAL "x86_64")
     set(TARGET_TRIPLE "${APPDIR}/tools/x86_64-unknown-nuttx.json")
   elseif(ARCHTYPE STREQUAL "x86")
@@ -148,9 +149,9 @@ function(nuttx_add_rust)
     set(TARGET_BASE ${RUST_TARGET})
   endif()

-  set(RUST_BUILD_DIR
-      ${CMAKE_CURRENT_BINARY_DIR}/${CRATE_NAME}/target)
-  set(RUST_LIB_PATH ${RUST_BUILD_DIR}/${TARGET_BASE}/${RUST_PROFILE}/lib${CRATE_NAME}.a)
+  set(RUST_BUILD_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CRATE_NAME}/target)
+  set(RUST_LIB_PATH
+      ${RUST_BUILD_DIR}/${TARGET_BASE}/${RUST_PROFILE}/lib${CRATE_NAME}.a)

   # Create build directory
   file(MAKE_DIRECTORY ${RUST_BUILD_DIR})

* Apply cmake-format. Signed-off-by: Shoji Tokunaga <toku@mac.com>

toku-mac · 2026-05-13T08:58:29Z

Sorry to bother you again.
I've pushed commit 4a20702.

lupyuen · 2026-05-13T09:06:11Z

Yep NuttX CI is happy now thanks :-)
https://github.com/apache/nuttx-apps/actions/runs/25788989417/job/75749503585?pr=3479

no1wudi · 2026-05-13T11:16:07Z

    set(RUST_PROFILE "release")
    set(RUST_PANIC_FLAGS "-Zunstable-options -Cpanic=immediate-abort")
  else()
+    set(RUST_PROFILE_FLAG "-Zjson-target-spec")


is it really needed for non x86 target?

Yes, currently APPDIR is only required for "x86_64" and "x86" architectures.
Should I put it inside the if hierarchy?

I guess if it's essential for x86 target and acceptable for other targets, you can move it to line 166 instead of dup them here?

lupyuen · 2026-05-13T12:21:52Z

@toku-mac While you're making changes, please squash all commits into One Single Commit. Thanks :-)

apps/cmake: Make hello_rust_cargo buildable with cmake

7a5ed3a

* Resolve APPDIR. * Remove "debug" from RUST_PROFILE_FLAG. * Add JSON specification compatibility to RUST_PROFILE_FLAG. * Correct the directory structure for RUST_LIB_PATH. Signed-off-by: Shoji Tokunaga <toku@mac.com>

lupyuen requested a review from simbit18 May 13, 2026 07:30

This was linked to issues May 13, 2026

[BUG] cmake: Fix invalid --debug argument in cargo build command #3472

Open

[BUG] Fix incorrect Rust library path in nuttx_add_rust.cmake #3473

Open

github-actions Bot added Area: Build System Size: XS labels May 13, 2026

apps/cmake: Make hello_rust_cargo buildable with cmake

a2fe197

* Correct the permissions of `nuttx_add_rust.cmake` to 644. Signed-off-by: Shoji Tokunaga <toku@mac.com>

toku-mac force-pushed the fix_cargo_cmake branch from 89b0558 to a2fe197 Compare May 13, 2026 08:46

apps/cmake: Make hello_rust_cargo buildable with cmake

4a20702

* Apply cmake-format. Signed-off-by: Shoji Tokunaga <toku@mac.com>

github-actions Bot added Size: S and removed Size: XS labels May 13, 2026

no1wudi reviewed May 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

apps/cmake: Make hello_rust_cargo buildable with cmake#3479

apps/cmake: Make hello_rust_cargo buildable with cmake#3479
toku-mac wants to merge 3 commits into
apache:masterfrom
toku-mac:fix_cargo_cmake

toku-mac commented May 13, 2026

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

toku-mac commented May 13, 2026

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

toku-mac commented May 13, 2026

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

no1wudi May 13, 2026

Uh oh!

toku-mac May 13, 2026

Uh oh!

no1wudi May 13, 2026

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

toku-mac commented May 13, 2026

Summary

Impact

Testing

PR verification Self-Check

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

toku-mac commented May 13, 2026

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

toku-mac commented May 13, 2026

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

no1wudi May 13, 2026

Choose a reason for hiding this comment

Uh oh!

toku-mac May 13, 2026

Choose a reason for hiding this comment

Uh oh!

no1wudi May 13, 2026

Choose a reason for hiding this comment

Uh oh!

lupyuen commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants