Skip to content

Fixing download of JDK 25 GH Actions #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahodaj merged 1 commit into from
May 13, 2026
Merged

Fixing download of JDK 25 GH Actions #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,7 @@ jobs:
- name: Set up Ubuntu dependencies
run: |
sudo apt update
sudo apt install openjdk-17-jdk openjdk-21-jdk

- name: Set up latest JDK 25 from jdk.java.net
uses: oracle-actions/setup-java@fff43251af9936a0e6a4d5d0946e14f1680e9b6b # v1.5.0
with:
website: jdk.java.net
release: 25
sudo apt install openjdk-17-jdk openjdk-21-jdk openjdk-25-jdk
Copy link
Copy Markdown

@jtulach jtulach May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses apt to install JDK 25 instead of relying on GitHub actions. That's looks as a sane aproach.

Copy link
Copy Markdown
Member

@neilcsmith-net neilcsmith-net May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Everywhere else we're using actions/setup-java. Why is this different? Could use https://github.com/actions/setup-java#install-multiple-jdks for this?

Copy link
Copy Markdown
Contributor Author

@lahodaj lahodaj May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this project does not currently require a fancy JDK, using one from the underlying distribution feels like a sensible compromise compared to potentially controversial distribution selection from setup-java.

OTOH, if you want to open a PR to change to setup-java, I don't object to that.

Copy link
Copy Markdown
Member

@neilcsmith-net neilcsmith-net May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, TCK == fancy! 😉

Just pointing out what we're doing on all the other repos.


- name: Set up NetBeans
run: |
Expand Down