Adding support for --limit-modules, --module-path and similar options.#44
Open
lahodaj wants to merge 5 commits into
Open
Adding support for --limit-modules, --module-path and similar options.#44lahodaj wants to merge 5 commits into
lahodaj wants to merge 5 commits into
Conversation
lahodaj
force-pushed
the
jdk9-options-support
branch
from
8799859 to
8bfea76
Compare
jtulach
reviewed
May 29, 2026
| if (modules.isEmpty()) { | ||
| throw new IllegalStateException("No modules!"); | ||
| try { | ||
| Class.forName("org.netbeans.ProxyURLStreamHandlerFactory").getMethod("register") |
There was a problem hiding this comment.
Nasty.
Why?
Why this is needed? To provide special support for protocols like nbfs? Or to override support for standard protocols like jar?
Fix
Shalln't we (finally) have a way to register the factory in a more standard way, not using reflection like this?
- according to javadoc "the ServiceLoader mechanism is used to locate URLStreamHandlerProvider implementations using the system class loader."
- why isn't
ProxyURLStreamHandlerFactoryregistered in service loader as URLStreamHandlerProvider then?
If it was, then this code could be replaced by for (var p : ServiceLoader.load(URLStreamHandlerProvider.class)) { } - e.g. just by iterating over public classes the support could be enabled.
Or am I over simplifying the problem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jackpot currently does not support
--add-modules,--add-exports,--limit-modulesand--system. This PR is trying to add support for these.