Skip to content

fix(docs): collapse three org-level security placeholder names into one - #1133

Merged
onlyarnav merged 1 commit into
apache:mainfrom
AmirF194:fix/1057-foundation-security-list-placeholder
Sep 1, 2026
Merged

fix(docs): collapse three org-level security placeholder names into one#1133
onlyarnav merged 1 commit into
apache:mainfrom
AmirF194:fix/1057-foundation-security-list-placeholder

Conversation

@AmirF194

Copy link
Copy Markdown
Contributor

Summary

  • The org-level advisory-admin security address had three names in the tree (<security-team-list>, <asf-security-list>, and the bare security_inbox.foundation_security_address config path) and none was registered in the placeholder table.
  • <asf-security-list> also bakes an ASF-specific name into a framework whose placeholder mechanism exists to keep adopting projects vendor-neutral.
  • Registers one org-neutral placeholder, <foundation-security-list>, and uses it at all three call sites. The distinct project-level <security-list> is untouched, since github-advisory.md's own delivery instructions deliberately address the two lists separately.

Type of change

  • Skill change (.claude/skills/<name>/) - eval fixtures updated below
  • Tool / bridge contract (tools/<system>/*.md)
  • Python package (tools/*/ with pyproject.toml)
  • Groovy reference impl
  • Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
  • Documentation (docs/, README.md, CONTRIBUTING.md)
  • Project template (projects/_template/)
  • CI / dev loop (prek, workflows, validators)
  • Other:

Test plan

  • prek run --all-files not available in this environment (no uv/prek); ran the individual hooks by hand instead: tools/dev/check-placeholders.sh, npx markdownlint-cli2 and typos on both changed files, and the doctoc check (no TOC change needed; skills/** is excluded from the doctoc hook and AGENTS.md's TOC is unaffected by a text-only edit). All clean.
  • PYTHONPATH=tools/skill-and-tool-validator/src python3 -c "from skill_and_tool_validator import main; main()" (the same entry point uv run skill-and-tool-validate calls) reports the same 29 pre-existing soft warnings before and after this change, none on the touched files.
  • Other: did not run the Python test matrix; this PR touches no tools/*/ package.

RFC-AI-0004 compliance

  • HITL - any new mutation is gated on explicit user confirmation
  • Sandbox - no new unrestricted host access; network reach declared in the adapter
  • Vendor neutrality - replaces an ASF-branded placeholder (<asf-security-list>) with an org-neutral one, matching <governance-body> and <project-stage>
  • Conversational + correctable - agentic-override path documented if behaviour is adopter-tunable
  • Write-access discipline - no autonomous outbound messages; drafts only, sent on confirmation
  • Privacy LLM - private content does not reach a non-approved LLM; redactor invoked where needed

Linked issues

Fixes #1057

Notes for reviewers (optional)

Followed the naming this issue itself suggests, matching the config key: <foundation-security-list> rather than <org-security-list>. projects/_template/project.md already documents security_inbox.foundation_security_address as org-level and inherited ("Do not declare it here"), so no change was needed there.

The org-level advisory-admin security address had three names in the
tree: <security-team-list> in github-advisory.md, <asf-security-list>
(twice) in AGENTS.md, and the bare config path
security_inbox.foundation_security_address in the placeholder table,
which had no row for it at all. AGENTS.md also baked an ASF-specific
name into a framework whose placeholder mechanism exists precisely to
keep adopting projects out of that vocabulary.

Register <foundation-security-list>, sourced from
security_inbox.foundation_security_address, and use it at all three
call sites. The distinct project-level <security-list> is untouched,
since the two addresses are deliberately different in
github-advisory.md's own delivery instructions.

Fixes apache#1057

Generated-by: Claude Code (Sonnet 5)

@onlyarnav onlyarnav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ready to merge.

@onlyarnav
onlyarnav merged commit 33bd241 into apache:main Sep 1, 2026
10 checks passed
@AmirF194

AmirF194 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Good, that closes out the placeholder collapse cleanly.

@AmirF194
AmirF194 deleted the fix/1057-foundation-security-list-placeholder branch September 2, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(placeholders): the org-level security address has three names and none is registered

2 participants